feat: add is_extended_promotional field to components (issue #92)#172
Open
Wong789 wants to merge 40 commits intotscircuit:mainfrom
Open
feat: add is_extended_promotional field to components (issue #92)#172Wong789 wants to merge 40 commits intotscircuit:mainfrom
Wong789 wants to merge 40 commits intotscircuit:mainfrom
Conversation
|
Gentle ping - this PR has been open since Apr 20. No CI failures detected. Ready for review when you get a chance. Thanks! |
|
Hi, just checking in — this PR has been open for a while. Could you take a look when you have a moment? Happy to address any feedback. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #92: Add is_extended_promotional column to components
Problem
Some parts on JLCPCB are 'extended promotional' which means they act as basic for a limited time. This information should be available as a filterable column.
Solution
is_extended_promotional: booleanto BaseComponent interfaceis_extended_promotionalto DerivedTableSpec Resource typeis_extended_promotionalfield to kysely.ts generated typesis_extended_promotional: Boolean(c.is_extended_promotional)to mapToTable function in all 39 derived table files/claim #92