fix: Add `is_extended_promotional ` column to components (from da by SyedHannanMehdi · Pull Request #158 · tscircuit/jlcsearch

SyedHannanMehdi · 2026-03-29T20:54:46Z

Automated fix for #92 — implemented by CashClaw agent.

Closes #92

…rce data

…dpoint

…nal type

graphite-app · 2026-03-29T20:58:15Z

+import { expect, test } from "bun:test"
+import { getComponentTypeFlags } from "./get-component-type"
+
+test("base → is_basic", () => {
+  expect(getComponentTypeFlags("base")).toEqual({
+    is_basic: 1,
+    is_preferred: 0,
+    is_extended_promotional: 0,
+  })
+})
+
+test("expand → is_preferred", () => {
+  expect(getComponentTypeFlags("expand")).toEqual({
+    is_basic: 0,
+    is_preferred: 1,
+    is_extended_promotional: 0,
+  })
+})
+
+test("extend → all false", () => {
+  expect(getComponentTypeFlags("extend")).toEqual({
+    is_basic: 0,
+    is_preferred: 0,
+    is_extended_promotional: 0,
+  })
+})
+
+test("promotion → is_extended_promotional", () => {
+  expect(getComponentTypeFlags("promotion")).toEqual({
+    is_basic: 0,
+    is_preferred: 0,
+    is_extended_promotional: 1,
+  })
+})
+
+test("promotionextend → is_extended_promotional", () => {
+  expect(getComponentTypeFlags("promotionextend")).toEqual({
+    is_basic: 0,
+    is_preferred: 0,
+    is_extended_promotional: 1,
+  })
+})
+
+test("numeric 0 → is_basic", () => {
+  expect(getComponentTypeFlags(0)).toEqual({
+    is_basic: 1,
+    is_preferred: 0,
+    is_extended_promotional: 0,
+  })
+})
+
+test("numeric 1 → is_preferred", () => {
+  expect(getComponentTypeFlags(1)).toEqual({
+    is_basic: 0,
+    is_preferred: 1,
+    is_extended_promotional: 0,
+  })
+})
+
+test("numeric 3 → is_extended_promotional", () => {
+  expect(getComponentTypeFlags(3)).toEqual({
+    is_basic: 0,
+    is_preferred: 0,
+    is_extended_promotional: 1,
+  })
+})
+
+test("null → all false", () => {
+  expect(getComponentTypeFlags(null)).toEqual({
+    is_basic: 0,
+    is_preferred: 0,
+    is_extended_promotional: 0,
+  })
+})
+
+test("undefined → all false", () => {
+  expect(getComponentTypeFlags(undefined)).toEqual({
+    is_basic: 0,
+    is_preferred: 0,
+    is_extended_promotional: 0,
+  })
+})
+
+test("case insensitive", () => {
+  expect(getComponentTypeFlags("PROMOTION")).toEqual({
+    is_basic: 0,
+    is_preferred: 0,
+    is_extended_promotional: 1,
+  })
+  expect(getComponentTypeFlags("Base")).toEqual({
+    is_basic: 1,
+    is_preferred: 0,
+    is_extended_promotional: 0,
+  })
+})


This test file contains 11 test() calls (lines 4, 12, 20, 28, 36, 44, 52, 60, 68, 76, 84), which violates the rule that a *.test.ts file may have AT MOST one test(). After the first test, the file should be split into multiple numbered files. To fix this, split the tests into separate files like: get-component-type1.test.ts, get-component-type2.test.ts, etc., with each file containing only one test() call.

Spotted by Graphite (based on custom rule: Custom rule)

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-03-29T20:58:16Z

+        basic: component.basic === 1,
+        preferred: component.preferred === 1,


Field name mismatch will cause runtime errors. The schema defines is_basic and is_preferred, but this code references component.basic and component.preferred which don't exist.

// Fix: basic: component.is_basic === 1, preferred: component.is_preferred === 1,

Suggested change

basic: component.basic === 1,

preferred: component.preferred === 1,

basic: component.is_basic === 1,

preferred: component.is_preferred === 1,

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-03-29T20:58:17Z

+          basic,
+          preferred,


Field names don't match the database schema. The components table has is_basic and is_preferred columns, not basic and preferred. This will cause insert failures.

// Fix: is_basic: basic, is_preferred: preferred,

Suggested change

basic,

preferred,

is_basic: basic,

is_preferred: preferred,

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2026-03-29T20:58:19Z

+
+        return {
+          lcsc,
+          mfr: String(p.componentCode ?? p.lcscPartNumber ?? ""),


The mfr field is being populated with the component code instead of the manufacturer name. Line 117 shows manufacturer is available from p.brandNameEn, but line 113 incorrectly assigns component codes to the mfr field.

// Fix: mfr: String(p.brandNameEn ?? ""),

Suggested change

mfr: String(p.componentCode ?? p.lcscPartNumber ?? ""),

mfr: String(p.brandNameEn ?? ""),

Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.

Copilot

Pull request overview

This PR aims to add an is_extended_promotional flag for JLCPCB components so “extended promotional” parts can be filtered in the app/API.

Changes:

Adds an is_extended_promotional column via new migration files and an additional “apply migrations” helper.
Introduces new import/population scripts that attempt to write the new flag during component ingestion.
Adds new (tRPC-style) component list/get endpoints and a utility (getComponentTypeFlags) + tests for mapping library type values.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 18 comments.

Show a summary per file

File	Description
scripts/populate-components.ts	New JSON→DB population script that attempts to add/write `is_extended_promotional`.
scripts/import-components.ts	New JSONL import script that maps raw records to DB rows (including promotional flag).
routes/components/list.ts	New list endpoint with filter support for `is_extended_promotional`.
routes/components/get.ts	New get endpoint that returns the promotional flag.
migrations/0011_add_is_extended_promotional.ts	Adds `is_extended_promotional` column (top-level migrations dir).
lib/db/migrations/0023_add_is_extended_promotional.ts	Adds `is_extended_promotional` column (lib/db migrations dir).
lib/db/apply-migrations.ts	Adds a bespoke migration runner that also adds `is_extended_promotional`.
lib/db/schema.ts	Updates/defines `ComponentsTable` to include `is_extended_promotional`.
lib/util/get-component-type.ts	Adds mapping helper to derive `is_extended_promotional` from raw library type values.
lib/util/get-component-type.test.ts	Adds tests for the mapping helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-29T21:02:34Z

+    is_extended_promotional:
+      t === "promotion" ||
+      t === "promotionextend" ||
+      t === "extended_promotional"


Elsewhere in this PR, promotional parts are sometimes identified with componentLibraryType values like expand_special, but this function doesn’t recognize that value. If expand_special appears in the source data, it should be mapped to is_extended_promotional here (or the PR should standardize on the same raw values everywhere).

Suggested change

t === "extended_promotional"

t === "extended_promotional" ||

t === "expand_special"

Copilot · 2026-03-29T21:02:34Z

+      .addColumn("price1", "real")
+      .addColumn("in_stock", "integer", (col) => col.notNull().defaultTo(0))
+      .addColumn("is_basic", "integer", (col) => col.notNull().defaultTo(0))
+      .addColumn("is_preferred", "integer", (col) =>


This migration system creates a components table with price1, in_stock, is_basic, and is_preferred columns, which doesn’t match the repo’s current db.sqlite3 schema (codegen shows price, basic, preferred, etc.). Since nothing calls applyMigrations today, this risks introducing a divergent schema path; consider removing it or aligning it to the real DB setup flow.

Suggested change

.addColumn("price1", "real")

.addColumn("in_stock", "integer", (col) => col.notNull().defaultTo(0))

.addColumn("is_basic", "integer", (col) => col.notNull().defaultTo(0))

.addColumn("is_preferred", "integer", (col) =>

.addColumn("price", "real")

.addColumn("basic", "integer", (col) => col.notNull().defaultTo(0))

.addColumn("preferred", "integer", (col) =>

Copilot · 2026-03-29T21:02:35Z

+import { createDb } from "../lib/db"
+import { readFileSync } from "node:fs"
+import { join } from "node:path"
+


createDb is imported from ../lib/db, but there is no lib/db module export or createDb symbol in this repo (DB access is done via lib/db/get-db-client). This script won’t run as-is; switch to the existing DB client factory used elsewhere (e.g., getDbClient) or add the missing module/export.

Suggested change

import { createDb } from "../lib/db"

import { readFileSync } from "node:fs"

import { join } from "node:path"

import { getDbClient } from "../lib/db/get-db-client"

import { readFileSync } from "node:fs"

import { join } from "node:path"

const createDb = getDbClient

Copilot · 2026-03-29T21:02:35Z

+    voltage_rating: raw.voltage_rating ?? null,
+    current_rating: raw.current_rating ?? null,
+    power_rating: raw.power_rating ?? null,
+    resistance: raw.resistance ?? null,
+    capacitance: raw.capacitance ?? null,


This return object also includes many derived columns (voltage_rating, current_rating, etc.) that aren’t present on the current components table. If these are intended, they need to be added via the DB optimization pipeline (and the generated Kysely types regenerated).

Copilot · 2026-03-29T21:02:35Z

@@ -0,0 +1,113 @@
+import { z } from "zod"
+import { publicProcedure } from "../../lib/trpc"
+import { getDb } from "../../lib/db/get-db"


getDb is imported from ../../lib/db/get-db, but that module doesn’t exist in this repo (DB access is via ctx.db in Winterspec routes or getDbClient from lib/db/get-db-client). This import will fail at server startup when routes are bundled.

Copilot · 2026-03-29T21:02:37Z

+  } catch {
+    // Column already exists — that's fine


This catch {} will also swallow non-“column already exists” failures (e.g. missing table, permission errors), which can lead to silent data corruption or partial imports. Prefer checking schema/PRAGMA first or narrowing the caught error condition.

Suggested change

} catch {

// Column already exists — that's fine

} catch (err) {

// Only ignore "column already exists" style errors; rethrow everything else.

if (

!(err instanceof Error) ||

!/duplicate column|already exists/i.test(err.message)

) {

throw err

}

Copilot · 2026-03-29T21:02:37Z

+    price1,
+    in_stock: Number(raw.stock ?? raw.stockCount ?? 0) > 0 ? 1 : 0,
+    is_basic,
+    is_preferred,
+    is_extended_promotional,
+    voltage_rating: raw.voltage_rating ?? null,


The mapped row includes price1, in_stock, is_basic, is_preferred, and is_extended_promotional, but the current components table schema uses price (string JSON), basic, and preferred (see lib/db/generated/kysely.ts Component). The upsert will fail unless the DB schema is changed to add these columns or the mapping is adjusted to match existing columns.

Copilot · 2026-03-29T21:02:38Z

+import { publicProcedure } from "../../lib/trpc"
+import { getDb } from "../../lib/db/get-db"
+


This route uses publicProcedure from ../../lib/trpc, but there is no lib/trpc in the repo and the server/router is Winterspec-based (routes export default withWinterSpec(...)). As written this file will fail to load when createWinterSpecBundleFromDir scans routes/ at startup.

Suggested change

import { publicProcedure } from "../../lib/trpc"

import { getDb } from "../../lib/db/get-db"

import { getDb } from "../../lib/db/get-db"

type PublicProcedure = {

input: <TInput>(schema: z.ZodType<TInput>) => {

query: (

handler: (opts: { input: TInput }) => Promise<unknown> | unknown,

) => (input: unknown) => Promise<unknown>

}

}

const publicProcedure: PublicProcedure = {

input: (schema) => ({

query:

(handler) =>

async (rawInput: unknown) => {

const input = schema.parse(rawInput)

return await handler({ input })

},

}),

}

Copilot · 2026-03-29T21:02:38Z

+import { parseArgs } from "node:util"
+import { createReadStream } from "node:fs"
+import * as readline from "node:readline"
+import { getDb } from "../lib/db/get-db"


getDb is imported from ../lib/db/get-db, but that module doesn’t exist in this repo (DB access is via lib/db/get-db-client). This script won’t run until the import is corrected or the missing module is added.

Suggested change

import { getDb } from "../lib/db/get-db"

import { getDb } from "../lib/db/get-db-client"

Copilot · 2026-03-29T21:02:38Z

+/**
+ * Script to import components from JLCPCB data source CSV/JSON files.
+ *
+ * Usage:
+ *   bun scripts/import-components.ts --file <path>
+ *


The header comment says the script imports “CSV/JSON files”, but the implementation reads line-delimited JSON (JSON.parse per line) and doesn’t handle CSV. Update the comment to JSONL, or implement actual CSV parsing.

graphite-app · 2026-03-30T03:58:44Z

+test("base parts return is_base=true and is_extended=false", () => {
+  const result = getComponentTypeFlags("base")
+  expect(result.is_base).toBe(true)
+  expect(result.is_extended).toBe(false)
+  expect(result.is_extended_promotional).toBe(false)
+})


This test file references properties (is_base, is_extended) that don't match the actual function interface. The getComponentTypeFlags function returns is_basic, is_preferred, and is_extended_promotional, but this test expects is_base and is_extended properties, indicating inconsistent API design and variable naming.

Suggested change

test("base parts return is_base=true and is_extended=false", () => {

const result = getComponentTypeFlags("base")

expect(result.is_base).toBe(true)

expect(result.is_extended).toBe(false)

expect(result.is_extended_promotional).toBe(false)

})

test("base parts return is_basic=true and is_preferred=false", () => {

const result = getComponentTypeFlags("base")

expect(result.is_basic).toBe(true)

expect(result.is_preferred).toBe(false)

expect(result.is_extended_promotional).toBe(false)

})

Spotted by Graphite (based on custom rule: Custom rule)

Is this helpful? React 👍 or 👎 to let us know.

SyedHannanMehdi added 13 commits March 30, 2026 01:15

feat: add migration for is_extended_promotional column

66de637

feat: add is_extended_promotional to ComponentsTable schema type

f4021a6

feat: update populate script to read is_extended_promotional from sou…

17e0517

…rce data

feat: expose and filter is_extended_promotional in components list en…

b8808e1

…dpoint

feat: expose is_extended_promotional in component get endpoint

3dc3867

feat: add migration for is_extended_promotional column

1e647c3

feat: add is_extended_promotional to database schema type

68aad45

feat: update import script to parse and store is_extended_promotional

c25dbda

feat: add is_extended_promotional filter to list components route

508e6b5

feat: add is_extended_promotional to Database schema interface

02cce31

feat: add migration 0003 for is_extended_promotional column

0a13383

feat: add getComponentTypeFlags utility for parsing extended promotio…

a9fbe21

…nal type

test: add unit tests for getComponentTypeFlags

90f6f42

Copilot AI review requested due to automatic review settings March 29, 2026 20:54

Copilot started reviewing on behalf of SyedHannanMehdi March 29, 2026 20:55 View session

graphite-app Bot reviewed Mar 29, 2026

View reviewed changes

Copilot AI reviewed Mar 29, 2026

View reviewed changes

SyedHannanMehdi added 13 commits March 30, 2026 02:57

split get-component-type tests: file 1 (base parts)

eb36453

split get-component-type tests: file 2 (extended parts)

925ade3

split get-component-type tests: file 3 (extended_promotional parts)

da20d1d

split get-component-type tests: file 4 (numeric 0 base)

16216b3

split get-component-type tests: file 5 (numeric 1 extended)

5205740

split get-component-type tests: file 6 (numeric 2 extended_promotional)

b57b93e

split get-component-type tests: file 7 (unknown string value)

28922e8

split get-component-type tests: file 8 (null/undefined input)

e103f7b

split get-component-type tests: file 9 (uppercase BASE)

4c2e4db

Add is_extended_promotional column to database schema

a2a4a0b

Add migration for is_extended_promotional column in get-db

5a4c8c9

Add is_extended_promotional parsing to populate-components script

f79e9c5

Add is_extended_promotional filter to components list route

c73240c

SyedHannanMehdi added 4 commits March 30, 2026 09:19

Add migration for is_extended_promotional column

e224ee3

Update setup-db to include is_extended_promotional column

f63241e

Add tests for is_extended_promotional filter

dd17e05

Add documentation for is_extended_promotional column

f4a269e

graphite-app Bot reviewed Mar 30, 2026

View reviewed changes

		basic: component.basic === 1,
		preferred: component.preferred === 1,

-          basic,
-          preferred,
+          is_basic: basic,
+          is_preferred: preferred,

	mfr: String(p.componentCode ?? p.lcscPartNumber ?? ""),
	mfr: String(p.brandNameEn ?? ""),

	t === "extended_promotional"
	t === "extended_promotional" \|\|
	t === "expand_special"

-  } catch {
-    // Column already exists — that's fine
+  } catch (err) {
+    // Only ignore "column already exists" style errors; rethrow everything else.
+    if (
+      !(err instanceof Error) ||
+      !/duplicate column|already exists/i.test(err.message)
+    ) {
+      throw err
+    }

		import { publicProcedure } from "../../lib/trpc"
		import { getDb } from "../../lib/db/get-db"

-import { publicProcedure } from "../../lib/trpc"
-import { getDb } from "../../lib/db/get-db"
+import { getDb } from "../../lib/db/get-db"
+type PublicProcedure = {
+  input: <TInput>(schema: z.ZodType<TInput>) => {
+    query: (
+      handler: (opts: { input: TInput }) => Promise<unknown> | unknown,
+    ) => (input: unknown) => Promise<unknown>
+  }
+}
+const publicProcedure: PublicProcedure = {
+  input: (schema) => ({
+    query:
+      (handler) =>
+      async (rawInput: unknown) => {
+        const input = schema.parse(rawInput)
+        return await handler({ input })
+      },
+  }),
+}

	import { getDb } from "../lib/db/get-db"
	import { getDb } from "../lib/db/get-db-client"

Conversation

SyedHannanMehdi commented Mar 29, 2026

Uh oh!

graphite-app Bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants