Skip to content

Add billiards app#553

Open
markgreinke wants to merge 12 commits into
tronbyt:mainfrom
markgreinke:add-billiards-app
Open

Add billiards app#553
markgreinke wants to merge 12 commits into
tronbyt:mainfrom
markgreinke:add-billiards-app

Conversation

@markgreinke

Copy link
Copy Markdown
Contributor

Simulates 4 billiards shots based on user chosen seed

@markgreinke markgreinke requested a review from tavdog as a code owner June 10, 2026 23:09

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Billiards simulation app and updates the Overwatch Meta app to fetch statistics from Blizzard instead of Overbuff. Feedback on the Overwatch Meta app highlights critical Starlark compatibility issues, including the unsupported use of lambda expressions for sorting, nested capturing groups in PCT_PATTERN that break re.findall, and a potential runtime crash caused by returning a render.Root from get_rates_list. Additionally, the new Billiards app is missing the required .webp preview image in its directory.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread apps/overwatch_meta/overwatch_meta.star Outdated
Comment thread apps/overwatch_meta/overwatch_meta.star Outdated
Comment thread apps/overwatch_meta/overwatch_meta.star
Comment thread apps/overwatch_meta/overwatch_meta.star
Comment thread apps/billiards/manifest.yaml
markgreinke and others added 5 commits June 10, 2026 16:35
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants