Fix XSS from smuggling spans into image attributes (#702, #703)#704
Merged
nicholasserra merged 3 commits intotrentm:masterfrom May 8, 2026
Merged
Fix XSS from smuggling spans into image attributes (#702, #703)#704nicholasserra merged 3 commits intotrentm:masterfrom
nicholasserra merged 3 commits intotrentm:masterfrom
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #702 and fixes #703.
702
For some reason, the
code_span_rehadre.Senabled, even though it was only for code spans? Not sure why as that's what fenced code blocks is for.Disabled it, only test suite issue was latex where for some reason the code blocks were being converted? Not sure why
703
Issue was, as with #699 and #691, smuggling spans into image attributes - the alt, title, link text and src.
This PR fixes being able to smuggle it into the title through clever quoting