Refactor(schema): cache find lookups in schema#7615
Merged
georgesittas merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
tobymao
approved these changes
May 6, 2026
geooo109
approved these changes
May 6, 2026
6b1abfc to
d25b627
Compare
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 113210 total, 112112 passed (pass rate: 99.0%), sqlglot version: sqlglot:jo/avoid_unnecessary_schema_lookups: 101037 total, 101037 passed (pass rate: 100.0%), sqlglot version: Transitions: Dialect pair changes: 0 previous results not found, 3 current results not found ✅ 43 test(s) passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benched this using
annotate_typeson a query with 2,400 columns references across 8 tables (8x60 cols, each referenced 5x).before (main): 35.9ms median, 33.7ms min
after (cache): 33.3ms median, 32.0ms min (~7% faster)
The gain is modest in wall-time because the trie walk itself is cheap. The main benefit is eliminating 2,400 redundant base
find()calls down to the number of unique (table, ensure_data_types) pairs.