chore(deps): update dependency cliwrap to 3.10.1#2463
Conversation
There was a problem hiding this comment.
Code Review
This is a straightforward Renovate-generated dependency bump of CliWrap from 3.10.0 → 3.10.1 in Directory.Packages.props.
Change Summary
- Single-line version bump in the centralized package management file — minimal blast radius.
Notable in 3.10.1
- Bug fix: Throws if failed to kill process during cancellation (Tyrrrz/CliWrap#308) — this is a correctness improvement that benefits ModularPipelines' command execution layer.
- AOT support improvement via
LibraryImportinstead ofDllImport. - Internal dependency/tooling updates (CPM migration, SourceLink cleanup).
Assessment
The change is safe to merge. The patch release contains a meaningful bug fix (process kill failure now propagates as an exception rather than silently failing), which is the correct behavior for a pipeline tool where cancellation reliability matters. No breaking changes are indicated, and the change is confined to the centralized package version — all consuming projects inherit it automatically.
✅ Approved.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | ✅ 0 (≤ 20 complexity) |
TIP This summary will be updated as you push new changes. Give us feedback
10800b8 to
185f87d
Compare
There was a problem hiding this comment.
Code Review (Follow-up)
This is a follow-up to the previous review posted on 2026-04-01. No new commits have been pushed since then, so this is a reconfirmation.
Change
Single-line version bump in Directory.Packages.props: CliWrap 3.10.0 → 3.10.1.
Previous review findings — still accurate
- The patch release carries a meaningful correctness fix: CliWrap now throws if it fails to kill a process during cancellation (Tyrrrz/CliWrap#308). For a pipeline tool that relies heavily on subprocess management, this is strictly better behavior than silently swallowing the failure.
- AOT compatibility improvement (
LibraryImportreplacingDllImport) is a future-proofing win with no runtime cost. - The change is confined to the centralized
Directory.Packages.props, so all consuming projects inherit it automatically with no additional edits required — this is the correct approach for a CPM-based solution. - No breaking changes are indicated in the release notes, and Codacy reports zero new issues.
Conclusion
No issues found. The update is safe, beneficial, and appropriately scoped. The PR has auto-merge enabled and is ready to land.
185f87d to
6373c16
Compare
There was a problem hiding this comment.
Code Review
This is a Renovate-generated patch bump of CliWrap from 3.10.0 to 3.10.1, applied correctly in the single source-of-truth location (Directory.Packages.props) under Centralized Package Management (CPM).
Change assessment
Scope: One line, one file. All projects that reference CliWrap inherit the update automatically — no per-project .csproj edits are needed or expected. This is the correct pattern for a CPM-managed solution.
What changed upstream in 3.10.1:
-
Process kill now throws on failure during cancellation (Tyrrrz/CliWrap#308) — this is the most relevant fix for ModularPipelines. Previously, if CliWrap failed to kill a spawned process when a
CancellationTokenwas cancelled, the failure was swallowed silently. Now it propagates as an exception. For a pipeline framework that wraps CLI tool execution, reliable cancellation is critical: a silent failure to kill could leave orphaned processes consuming resources or producing side-effects after a pipeline is cancelled. The new behavior surfaces the problem so callers can act on it. -
AOT compatibility (
LibraryImportreplacingDllImport) — future-proofing with no runtime cost or behavioral change for JIT scenarios. -
Internal tooling/dependency hygiene (CPM migration, SourceLink cleanup) — no consumer impact.
No concerns
- The diff is minimal and mechanically correct.
- No breaking API changes are indicated in the release notes.
- The patch version increment is semantically appropriate for a bug fix + internal improvements.
- Static analysis (CodeFactor) reports no new issues.
- Snyk reports no new manifest-level security concerns.
Previous reviews on this PR (from 2026-04-01 and earlier today) reached the same conclusion, and nothing has changed since then.
Verdict: safe and beneficial to merge.
6373c16 to
f60119f
Compare
There was a problem hiding this comment.
Code Review
This is a Renovate-generated patch bump of CliWrap 3.10.0 → 3.10.1 applied in Directory.Packages.props.
Prior reviews
Three previous reviews on this PR (2026-04-01 and 2026-04-05) already assessed this change. No new commits have been pushed since the last review, so this is a reconfirmation with a fresh look at CI state.
Assessment
Change scope: One line in Directory.Packages.props. All projects consuming CliWrap inherit the update automatically via CPM — no per-project .csproj edits are required or present. Correct approach.
What 3.10.1 brings (relevant to this codebase):
- Process kill now throws on failure during cancellation (Tyrrrz/CliWrap#308). For a pipeline framework built around CLI subprocess execution, this is a strictly better behavior: previously a failure to kill a cancelled process was silently swallowed, which could leave orphaned processes producing side-effects after cancellation. The new behavior surfaces the failure so callers can handle it.
LibraryImportreplacingDllImportfor AOT correctness — no behavioral change for JIT consumers, but forward-looking.- No breaking API changes.
CI: CodeFactor and Snyk both pass with no new issues. Pipeline jobs are queued/running at review time.
Verdict: Safe and beneficial to merge. No concerns.
f60119f to
b1e5090
Compare
There was a problem hiding this comment.
Code Review
This is a Renovate-generated patch bump of CliWrap 3.10.0 → 3.10.1 in Directory.Packages.props.
Prior reviews
Five previous reviews on this PR have already assessed this change in detail. No new commits have been pushed, so this is a final reconfirmation.
Summary
- Scope: Single line in
Directory.Packages.props. CPM propagates the update to all consuming projects automatically — the correct approach. - Key upstream fix: Process kill now throws on failure during cancellation (Tyrrrz/CliWrap#308), which is strictly better behavior for a pipeline framework that wraps subprocess execution. Silent failures during cancellation could leave orphaned processes; surfacing the exception enables callers to handle it.
- No breaking changes in the release notes.
- CI: Codacy reports zero new issues.
Verdict
Safe and beneficial to merge. No concerns.
b1e5090 to
6647eb9
Compare
There was a problem hiding this comment.
Code Review: CliWrap 3.10.0 → 3.10.1 Dependency Update
This is a straightforward patch-version bump of CliWrap, a core dependency used for command execution across ModularPipelines.
Change: Directory.Packages.props — single line version bump from 3.10.0 to 3.10.1.
Notable in 3.10.1
- Process kill on cancellation: Previously, if killing a process during cancellation failed, the error was silently swallowed. It now throws — this is a correctness improvement for cancel scenarios.
- AOT support improvement: Switched from
DllImporttoLibraryImportfor better Native AOT compatibility. - Internal dependency and tooling updates only (no public API changes).
Assessment
The change is minimal, correct, and safe. The patch release contains only a bug fix (throw on failed kill during cancellation) and AOT improvements — no breaking changes. This aligns well with ModularPipelines' use of CliWrap for process execution, and the improved cancellation behavior is a net positive since pipelines rely heavily on cancellation tokens.
No concerns. Good to merge.
6647eb9 to
a68285a
Compare
There was a problem hiding this comment.
Code Review
This is a Renovate Bot dependency update bumping CliWrap from 3.10.0 → 3.10.1 (patch version).
Change Summary
Single line change in Directory.Packages.props updating the centralized package version for CliWrap.
Assessment: ✅ Looks good
Why this is safe to merge:
-
Patch release:
3.10.0→3.10.1follows semver, meaning only bug fixes — no breaking changes expected. -
Notable fix in 3.10.1: The release includes "Throw if failed to kill process during cancellation" (#308). This is actually a meaningful improvement for ModularPipelines — since the framework relies on CliWrap for process execution and has cancellation support, this fix ensures cancellation failures are surfaced as exceptions rather than silently swallowed, which aligns well with the project's reliability goals.
-
Correct use of CPM: The change is made only in
Directory.Packages.props(Centralized Package Management), which is the right place. No individual.csprojfiles need updating. -
AOT improvement: The
LibraryImportoverDllImportchange in CliWrap is a nice forward-looking improvement for any AOT scenarios.
No concerns with this update — the patch brings a meaningful bug fix with no risk of regression.
This PR contains the following updates:
3.10.0→3.10.1Release Notes
Tyrrrz/CliWrap (CliWrap)
v3.10.1Compare Source
What's Changed
LibraryImportinstead ofDllImportfor proper AOT support by @Copilot in #323New Contributors
Full Changelog: Tyrrrz/CliWrap@3.10...3.10.1
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.