kmod_scripts: add support for snd_soc_cml_rt1011_rt5682#2198
Merged
jajanusz merged 1 commit intothesofproject:masterfrom Dec 13, 2019
Merged
kmod_scripts: add support for snd_soc_cml_rt1011_rt5682#2198jajanusz merged 1 commit intothesofproject:masterfrom
jajanusz merged 1 commit intothesofproject:masterfrom
Conversation
jajanusz
approved these changes
Dec 12, 2019
plbossart
requested changes
Dec 12, 2019
Member
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
almost good but minor reorder needed
tools/kmod_scripts/sof_remove.sh
Outdated
Member
There was a problem hiding this comment.
no, this is in the wrong location. we group machine drivers together, then codec drivers. This should inserted line 46
Collaborator
Author
There was a problem hiding this comment.
@plbossart Thank you, Pierre. Now it is at line 46.
Add snd_soc_cml_rt1011_rt5682 module removal support for CML with rt1011 and rt5682 codecs. Signed-off-by: Amery Song <chao.song@intel.com>
plbossart
approved these changes
Dec 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After Kernel PR #1565 being merged, correct driver is loaded on CML with rt1011 and rt5682, we got one more module need to be removed in module unload/reload test
this patch add snd_soc_cml_rt1011_rt5682 module removal support for CML platform with rt1011 and rt5682 codecs.