[BUG] /proc/asound/sofprobes breaks "check-sof-logger" test

[harajend]

Describe the bug
"check-sof-logger" test failed with error message "[ERROR] SOF ALSA card not available, driver probe fail?"

Triage details
Test case passed upon modified line 74 in the "check-sof-logger.sh" file
Original code: "test -e /proc/asound/sof*/id"
Modified code: "test -e /proc/asound/sofs*/id"
Cause: Above command line is looking for "sofsoundwire" directory, but in this case 2 directories were located for "sof"* string match

To Reproduce

1. Launch Terminal and Run "TPLG=/lib/firmware/intel/sof-ipc4-tplg/sof-ptl-rt722-4ch.tplg MODEL=PTLP_RVP_SDW SOF_TEST_INTERVAL=5 ~/sof-test/test-case/check-sof-logger.sh"

Expected behavior

• Test should PASS

Detail Info

1. Linux kernel and SOF Firmware details:

   • Linux Build Result: 2842
   • Linux Branch: topic/sof-dev
   • Linux Commit: 89772eb035b4
   • KConfig Branch: master
   • KConfig Commit: 097c69ae4b81
   • SOF Build Result: 6015
   • SOF Branch: main
   • SOF Commit: f4cd55c2e879
   • Zephyr Commit: 7fa8bf17563b
   • SOF TEST PR: 1240

2. Test report ID (if you find it from test report)

   • ID: #48234

3. Test DUT Model (or a brief discribtion about the device)

   • MODEL: {PTLP_RVP_SDW}

4. Test TPLG

   • TPLG: {/lib/firmware/intel/sof-ipc4-tplg/sof-ptl-rt722-4ch.tplg}

5. Test case (what test script and how you run it)

   • TESTCASE: check-sof-logger.sh

Screenshots or console output

Failed logs

• https://sof-ci.ostc.intel.com/#/result/planresultdetail/48234?model=PTLP_RVP_SDW&testcase=check-sof-logger

[marc-hb]

Avoid screenshots when not necessary, use copy/paste:
https://docs.zephyrproject.org/latest/develop/getting_started/index.html#use-copy-paste

but in this case 2 directories were located for "sof"*

This is a real bug in check-sof-logger.sh, line 74 should be modified. That line is not compatible with /proc/asound/sofprobes.

Why did you close it?

[harajend]

I re-file it privately, since this issue i found in PTL. So i thought to avoid it in Public git page.

[marc-hb]

This bug is not specific to PTL, it's caused by SOF probes which are not specific to PTL.

If you are not sure, start with a private bug first, otherwise it's a bit too late :-)

The fix should be as simple as this below, could you try it and submit it?

--- a/test-case/check-sof-logger.sh
+++ b/test-case/check-sof-logger.sh
@@ -68,10 +68,8 @@ func_lib_check_sudo
 
 sof_alsa_card_found()
 {
-    # note: assumes SOF card names to start with "sof", e.g.
-    #   - /proc/asound/sofsoundwire/id
-    #   - /proc/asound/sofhdadsp/id
-    test -e /proc/asound/sof*/id
+    test -e /proc/asound/sofsoundwire/id ||
+        test -e /proc/asound/sofhdadsp/id
 }
 
 wait_for_sof_alsa_card()