ASoC: sdw_utils: avoid the SDCA companion function not supported failure#5723
ASoC: sdw_utils: avoid the SDCA companion function not supported failure#5723oortcomet wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
oortcomet
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
|
Can one of the admins verify this patch?
|
There was a problem hiding this comment.
Pull request overview
This PR updates the SoundWire ASoC SDW utils helper logic to treat the SDCA “CompanionAmp” function type as a generic AMP DAI type, avoiding endpoint-skipping/failures when this SDCA function is present but not fully supported.
Changes:
- Map
SDCA_FUNCTION_TYPE_COMPANION_AMPtoSOC_SDW_DAI_TYPE_AMPinasoc_sdw_get_dai_type().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| switch (type) { | ||
| case SDCA_FUNCTION_TYPE_SMART_AMP: | ||
| case SDCA_FUNCTION_TYPE_SIMPLE_AMP: | ||
| case SDCA_FUNCTION_TYPE_COMPANION_AMP: |
There was a problem hiding this comment.
I would reword the commit message to be more positive:
Treat the companion amp as generic AMP until full support for companion amp is added.
There was a problem hiding this comment.
Yeah, agree but the code looks all good to me.
There was a problem hiding this comment.
OK. Will update the commit message.
Treat the companion amp as generic AMP until full support for companion amp is added. Signed-off-by: Derek Fang <derek.fang@realtek.com>
oortcomet
force-pushed
the
rz-rt721-rt1320
branch
from
da5f53b to
2f0f575
Compare
Since the SDCA companion function is not fully supported, it is temporarily treated as a general amp type.