Support non-http schemas in url refs#75
Conversation
These url schemes were already valid for inline linking. This adds the ability to use them as url references as well.
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
===========================================
+ Coverage 98.83% 100.00% +1.16%
===========================================
Files 11 12 +1
Lines 1206 1199 -7
Branches 221 222 +1
===========================================
+ Hits 1192 1199 +7
+ Misses 14 0 -14
Continue to review full report at Codecov.
|
sebix
left a comment
There was a problem hiding this comment.
The change itself is fine for me, thanks for the contribution.
But I see, that the regular expression pattern is compiled on every function call, we can move this to the constructor, where all the other patterns are compiled as well, to gain some performance.
I'll add that change as well. Thank you. |
These url schemes were already valid for inline linking. This adds
the ability to use them as url references as well.