-
Notifications
You must be signed in to change notification settings - Fork 541
Add coverage for uvalue "true" and "yes" #5016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anba
wants to merge
1
commit into
tc39:main
Choose a base branch
from
anba:locale-yes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+98
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
36 changes: 36 additions & 0 deletions
36
test/intl402/Locale/constructor-unicode-extension-uvalue-true.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // Copyright 2026 André Bargull. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| /*--- | ||
| esid: sec-intl.locale | ||
| description: > | ||
| Remove any uvalue (aka type) equal to "true". | ||
| info: | | ||
| Intl.Locale ( tag [ , options ] ) | ||
| ... | ||
| 13. Set tag to CanonicalizeUnicodeLocaleId(tag). | ||
| ... | ||
| 35. Let r be MakeLocaleRecord(tag, opt, localeExtensionKeys). | ||
| ... | ||
| features: [Intl.Locale] | ||
| ---*/ | ||
|
|
||
| // Generate all possible `ukey` values. | ||
| function* ukeys() { | ||
| const lowerA = 'a'.charCodeAt(0); | ||
| const lowerZ = 'z'.charCodeAt(0); | ||
|
|
||
| for (let first = lowerA; first <= lowerZ; ++first) { | ||
| for (let second = lowerA; second <= lowerZ; ++second) { | ||
| yield String.fromCharCode(first, second); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| for (let ukey of ukeys()) { | ||
| assert.sameValue( | ||
| new Intl.Locale(`en-u-${ukey}-true`).toString(), | ||
| `en-u-${ukey}`, | ||
| `new Intl.Locale("en-u-${ukey}-true").toString() returns "en-u-${ukey}"` | ||
| ); | ||
| } | ||
62 changes: 62 additions & 0 deletions
62
test/intl402/Locale/constructor-unicode-extension-uvalue-yes.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // Copyright 2026 André Bargull. All rights reserved. | ||
| // This code is governed by the BSD license found in the LICENSE file. | ||
|
|
||
| /*--- | ||
| esid: sec-intl.locale | ||
| description: > | ||
| Remove any uvalue (aka type) equal to "true". | ||
| info: | | ||
| Intl.Locale ( tag [ , options ] ) | ||
| ... | ||
| 13. Set tag to CanonicalizeUnicodeLocaleId(tag). | ||
| ... | ||
| 35. Let r be MakeLocaleRecord(tag, opt, localeExtensionKeys). | ||
| ... | ||
| features: [Intl.Locale] | ||
|
anba marked this conversation as resolved.
|
||
| ---*/ | ||
|
|
||
| // Generate all possible `ukey` values. | ||
| function* ukeys() { | ||
| const lowerA = 'a'.charCodeAt(0); | ||
| const lowerZ = 'z'.charCodeAt(0); | ||
|
|
||
| for (let first = lowerA; first <= lowerZ; ++first) { | ||
| for (let second = lowerA; second <= lowerZ; ++second) { | ||
| yield String.fromCharCode(first, second); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| function canonicalizeUValue(ukey, uvalue) { | ||
| assert.sameValue(uvalue, "yes", "unexpected uvalue"); | ||
|
|
||
| switch (ukey) { | ||
| case "kb": | ||
| case "kc": | ||
| case "kh": | ||
| case "kk": | ||
| case "kn": | ||
| // Canonicalized to "true", which then gets removed. | ||
| return ""; | ||
| default: | ||
| return uvalue; | ||
| } | ||
| } | ||
|
|
||
| for (let ukey of ukeys()) { | ||
| let canonicalized = new Intl.Locale(`en-u-${ukey}-yes`).toString(); | ||
|
|
||
| if (canonicalizeUValue(ukey, "yes") === "yes") { | ||
| assert.sameValue( | ||
| canonicalized, | ||
| `en-u-${ukey}-yes`, | ||
| `new Intl.Locale("en-u-${ukey}-yes").toString() returns "en-u-${ukey}-yes"` | ||
| ); | ||
| } else { | ||
| assert.sameValue( | ||
| canonicalized, | ||
| `en-u-${ukey}`, | ||
| `new Intl.Locale("en-u-${ukey}-yes").toString() returns "en-u-${ukey}"` | ||
| ); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.