Fix groups.update not appending ?asJob=True to URL when as_job=True#1770
Closed
Copilot wants to merge 1 commit intodevelopmentfrom
Closed
Fix groups.update not appending ?asJob=True to URL when as_job=True#1770Copilot wants to merge 1 commit intodevelopmentfrom
groups.update not appending ?asJob=True to URL when as_job=True#1770Copilot wants to merge 1 commit intodevelopmentfrom
Conversation
Copilot
AI
changed the title
[WIP] Fix groups.update to handle as_job parameter correctly
Fix Apr 7, 2026
groups.update not appending ?asJob=True to URL when as_job=True
Copilot stopped work on behalf of
jacalata due to an error
April 7, 2026 00:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling
server.groups.update(group, as_job=True), theasJobquery parameter was never added to the request URL, so the server returned aGroupItemresponse instead of aJobItem, causing anIndexErrorwhen the code tried to parse it as a job.Changes
groups_endpoint.py: Appends?asJob=Trueto the URL whenas_job=True, and raisesValueErrorearly for local groups (which don't support async updates)test/test_group.py: Addstest_update_ad_async(verifiesJobItemis returned) andtest_update_local_async(verifiesValueErrorfor local groups)test/assets/group_update_async.xml: Adds fixture with a minimal async job response