feat: allow commands to receive File objects#15978
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 8e27b76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
reviewed
Jun 8, 2026
Comment on lines
+329
to
+330
| const bytes = text_encoder.encode(json_string); | ||
| return base64_encode(bytes).replaceAll('=', '').replaceAll('+', '-').replaceAll('/', '_'); |
Member
There was a problem hiding this comment.
A little nit: we could deduplicate this here and in stringify_remote_arg. Maybe a url_friendly_base64_encode 🤔
teemingc
approved these changes
Jun 8, 2026
elliott-with-the-longest-name-on-github
approved these changes
Jun 8, 2026
elliott-with-the-longest-name-on-github
left a comment
elliott-with-the-longest-name-on-github
left a comment
Contributor
There was a problem hiding this comment.
LGTM, agree with Tee
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
Jun 8, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/kit@2.64.0 ### Minor Changes - feat: allow commands to receive `File` objects ([#15978](#15978)) ### Patch Changes - fix: avoid server components from being bundled if SSR is turned off for a route ([#15982](#15982)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
Does this close this issue?: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it's generally better to use a
<form>to deal with files, sometimes it imposes unreasonable constraints on a design. In these cases it would be nice to be able to passFileobjects to acommand.A short while ago, devalue added a
stringifyAsyncmethod that makes this possible — we just need a custom reducer that returns aPromise. We could potentially use the same trick for other things in future, or even allow async custom transports, but for now this is deliberately narrowly scoped.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits