test(util): lock supportsReadBigInts across node 22+ matrix#27
Open
solomonneas wants to merge 1 commit intosteipete:mainfrom
Open
test(util): lock supportsReadBigInts across node 22+ matrix#27solomonneas wants to merge 1 commit intosteipete:mainfrom
solomonneas wants to merge 1 commit intosteipete:mainfrom
Conversation
The gate was tightened in f7e594c to `major >= 22`, fixing the Chrome cookie expires_utc bigint break described in steipete#25. The accompanying test only spot-checks 22.0.0, 24.4.0, and 21.9.0, which leaves the 24.0-24.3 window the old gate dropped on the floor. Expand the matrix to cover: - supported: 22.0/22.5/22.11/22.22, 23.0, 24.0/24.3/24.4/24.10, 25.0, 30.5, 99.9 - unsupported: 18.20, 20.18, 21.7, 21.9, empty, non-numeric Reverting the gate to the pre-f7e594c form fails this test on the first 22.0.0 iteration, so a future "tidy-up" of the gate cannot silently re-break Node < 24.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
supportsReadBigInts()gate was tightened in f7e594c tomajor >= 22, fixing the Chrome >=146 cookie expires_utc bigint break described in #25. The accompanying test only spot-checks 22.0.0, 24.4.0, and 21.9.0, which leaves the 24.0-24.3 window the old gate dropped on the floor completely uncovered.Expand the matrix to:
Reverting the gate to the pre-f7e594c form fails this test on the first iteration, so a future "tidy-up" of the gate cannot silently re-break Node < 24.4.
Tests-only, no source or behavior changes.
Test plan
pnpm test(80 passed, 16 skipped, unchanged from baseline)pnpm test:bun(1 passed)pnpm lint(0 warnings, 0 errors)pnpm format:check(clean)pnpm typecheck(clean)pnpm build(clean)major === 24 ? minor >= 4 : falseform