feat(browser): explain browser control before runs#179
Merged
steipete merged 3 commits intosteipete:mainfrom May 6, 2026
Merged
feat(browser): explain browser control before runs#179steipete merged 3 commits intosteipete:mainfrom
steipete merged 3 commits intosteipete:mainfrom
Conversation
278429c to
25ed018
Compare
Contributor
Author
|
Rebased onto current upstream |
25ed018 to
635a1c8
Compare
635a1c8 to
7752295
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--browser-attach-runningignore conflicting launch-only defaults from user config, while still allowing explicitly provided conflicts to fail validationWhy
Agents such as Claude Code can look stuck during long browser-backed GPT-5.5 Pro consults, and visible Chrome automation can surprise the operator. This PR keeps behavior explicit before touching ChatGPT and makes the attach-running path usable even when a user config defaults to manual-login browser launches.
Tests
pnpm install --frozen-lockfilepnpm vitest run tests/cli/browserDefaults.test.ts tests/cli/browserConfig.test.ts tests/cli/dryRun.test.ts tests/cli/dryRun.coverage.test.ts tests/browser/controlPlan.test.ts tests/browser/sessionRunner.test.tspnpm run checkpnpm run buildpnpm testgit diff --checkSmoke / Dogfood
node ./dist/bin/oracle-cli.js --dry-run summary --engine browser --model gpt-5.5-pro --browser-attach-running -p "CHECK_CONTROL_PLAN" --file README.mdBrowser control: attach to an already-running local Chrome sessionwithout inheriting manual-login config conflictscalmer-browser-ux-review:ACCEPTABLEcalmer-browser-ux-review-2:ACCEPTABLE; during the wait it emitted[browser] Waiting for ChatGPT response ..., matching the agent-facing progress case this PR documents