Add macOS arm64 CLI release workflow#839
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f708e73fa1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| install -m 0755 "$BIN_DIR/CodexBarCLI" "$OUT_DIR/CodexBarCLI" | ||
| ln -s "CodexBarCLI" "$OUT_DIR/codexbar" | ||
|
|
||
| ASSET="CodexBarCLI-${TAG}-macos-arm64.tar.gz" |
There was a problem hiding this comment.
Sanitize ref name before using it in asset filename
When this workflow is run via workflow_dispatch, GITHUB_REF_NAME is typically the selected branch name, and branch names commonly contain / (for example feature/foo). Interpolating that value directly into ASSET makes tar czf "$ASSET" treat part of the filename as subdirectories, which fails because those directories are not created, so the packaging step breaks and manual runs cannot produce artifacts from such branches.
Useful? React with 👍 / 👎.
|
Test status update:\n- validated local Apple Silicon launch path using \n- process stays alive during runtime checks\n- release workflow updated to sanitize branch names for workflow_dispatch artifact packaging\n\nThis PR adds macOS arm64 CLI release artifacts to GitHub Releases for Apple Silicon users (including MacBook Air M5). |
|
Addressed. The ref-name sanitization feedback is fixed in commit 8c666a6 () so branch names containing no longer break artifact packaging. |
|
Addressed. The ref-name sanitization feedback is fixed in commit 8c666a6.
So |
|
Closed as covered by the consolidated release-workflow change landed on main in 0966118. I kept this in the existing release CLI workflow rather than adding a second macOS-only workflow, and included both macOS arm64 and x86_64 tarballs plus smoke tests and docs/changelog updates. Verified with local macOS arm64 CLI smoke, Linux CLI CI, and green CI after rerun. Thanks @mondary! |
Summary
CodexBarCLIfor macOS Apple Silicon (arm64).tar.gz+.sha256) and workflow artifacts for manual runsWhy
This makes Apple Silicon users (including MacBook Air M5) first-class release targets with ready-to-download CLI artifacts from GitHub Releases.
Validation
swift build -c release --arch arm64 --product CodexBarCLI