Wrap long status blurbs in menu#543
Merged
ratulsarna merged 2 commits intosteipete:mainfrom Mar 18, 2026
Merged
Conversation
Contributor
Author
|
before |
ratulsarna
reviewed
Mar 17, 2026
| } | ||
|
|
||
| private func makeWrappedSecondaryTextItem(text: String, width: CGFloat) -> NSMenuItem { | ||
| let item = NSMenuItem() |
Collaborator
There was a problem hiding this comment.
Should this wrapped menu item also preserve the real blurb in item.title? Right now it’s created with NSMenuItem(), which seems to leave the title as NSMenuItem, so it may be worth checking what code paths or accessibility behavior still rely on the menu item’s title rather than the custom view.
Contributor
Author
There was a problem hiding this comment.
Good point. I agree the wrapped item should still preserve the real blurb in item.title, not just in the custom view. I'll update it so we keep the original string on the NSMenuItem and use the view only for wrapping/layout.
Collaborator
|
Thanks @zkforge ! |
pablogtzgileta
pushed a commit
to pablogtzgileta/CodexBar
that referenced
this pull request
Apr 8, 2026
* Wrap long status blurbs in menu * Preserve wrapped status blurb titles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pnpm check./Scripts/compile_and_run.shswift test(hit an existingswiftpm-testing-helper/ AppKitSIGSEGVduring runner drawing; crash report captured at~/Library/Logs/DiagnosticReports/swiftpm-testing-helper-2026-03-16-233445.ips)