Skip to content

Tighten up publishing security#5517

Merged
Andarist merged 2 commits intomainfrom
env-gate
May 6, 2026
Merged

Tighten up publishing security#5517
Andarist merged 2 commits intomainfrom
env-gate

Conversation

@Andarist
Copy link
Copy Markdown
Collaborator

@Andarist Andarist commented May 6, 2026

No description provided.

@Andarist Andarist requested a review from davidkpiano May 6, 2026 07:07
runs-on: ubuntu-latest

environment: npm
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is the biggest change here. And it's going to get slightly more annoying to publish packages with it.

With this env-based "gate" after merging a Version Packages PR, you will be prompted (through notifications/email) to approve this publishing job. At least when you set up the required reviewers for this env (which you should do).

Why this should be done? To decouple repo write access from publish rights. Without this anyone with write access to the repo can potentially land a malicious Version Packages PR.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2026

⚠️ No Changeset found

Latest commit: 03b1310

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Andarist Andarist merged commit 811c71c into main May 6, 2026
1 check passed
@Andarist Andarist deleted the env-gate branch May 6, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant