esm is broken by change in Node.js

[targos]

Found the breakage with CITGM while preparing Node.js 12.5.0.

From this PR: nodejs/node#21387
Affected code:

esm/src/fs/stat-fast.js

Line 9 in 6feb50b

const { isFile } = Stats.prototype

The isFile method is no longer directly on Stats.prototype but on StatsBase.prototype instead.
The code should theoretically still work because the prototype chain is setup with Object.setPrototypeOf(Stats.prototype, StatsBase.prototype);. My guess is that it's broken because the setup of safe/fs.js does not handle this correctly.

[jdalton]

Ah, thank you @targos for the ping. I'll dig into this. I'll try to release a patch ASAP after finding the root cause. Out of curiosity which project is being checked by CITGM?

[targos]

@jdalton You can see the failing modules here: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1878/nodes=fedora-latest-x64/
citgm.clinic-v4.1.0
citgm.fastify-v2.5.0
citgm.semver-v6.1.1
citgm.split2-v3.1.1

[mcollina]

It's the https://www.node-tap.org/ test framework that is breaking because of this.

[targos]

Is there a path to fix this? I don't want to hold nodejs/node#21387 out of v12.x for too long.

[jdalton]

Hi @targos!

Yes, there's totally a path to fix this. I'll try to tackle it within a day (hold me to hit) and I'll keep you posted.

Update:

I got one set of failing tests to pass. Now wrapping up new failing test262 tests.

Update:

Got other set of failing test262 tests to pass. On to the actual issue now :)

Update:

Patched to potentially resolve issue 4f35a24.

[BridgeAR]

@jdalton thanks a lot for looking into this!

[mcollina]

@jdalton any updates on this? Thanks!