This repository was archived by the owner on Jan 21, 2025. It is now read-only.
Enable logging configuration via config file #13
Merged
pettermahlen merged 4 commits intospotify:masterfrom Aug 3, 2016
Merged
Enable logging configuration via config file #13pettermahlen merged 4 commits intospotify:masterfrom
pettermahlen merged 4 commits intospotify:masterfrom
Conversation
This is intended to support the same logging functionality as LoggingConfigurator, but to be configurable via the standard logback configuration methods.
Member
Author
- rename EnvironmentVariableSyslogAppender to SpotifyInternalAppender - improve javadocs - remove ability to configure environment variables, since logback provides support for that out of the box.
| } | ||
|
|
||
| @Test | ||
| public void shouldAddIdentToSuffixPattern() throws Exception { |
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds (yet) another SyslogAppender subclass that replicates some of the configuration
setup done by LoggingConfigurator. The idea is to make it possible to easily use a regular logback.xml file and not have to use the programmatic API exposed by LoggingConfigurator.
An example logback.xml file illustrating usage: