docs(dremio): correct PAT terminology in deployment troubleshooting#1844
Open
claudespice wants to merge 1 commit into
Open
docs(dremio): correct PAT terminology in deployment troubleshooting#1844claudespice wants to merge 1 commit into
claudespice wants to merge 1 commit into
Conversation
The Dremio connector authenticates with username/password only (Credentials::new(username, password) in connector-dremio/src/lib.rs); it has no personal-access-token parameter. The UNAUTHENTICATED troubleshooting row referenced an 'expired PAT' and 'regenerate the PAT', contradicting the page's own username/password auth section. Reworded to reference the dremio_username/dremio_password credentials.
✅ Pull with Spice PassedPassing checks:
|
1 similar comment
✅ Pull with Spice PassedPassing checks:
|
🔍 Pull with Spice FailedPassing checks:
Failed checks:
Please address these issues and update your pull request. |
✅ Pull with Spice PassedPassing checks:
|
|
🚀 deployed to https://a1c9529a.spiceai-org-website.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Dremio data connector authenticates with username/password only —
Credentials::new(username, password)(connector-dremio/src/lib.rs), and itsPARAMETERSarray exposes exactlydremio_endpoint,dremio_username,dremio_password. There is no personal-access-token (PAT) parameter.The
UNAUTHENTICATEDtroubleshooting row in the Dremio deployment guide referenced an "expired PAT" and told users to "regenerate the PAT via Dremio UI." This contradicted the page's own Authentication section (which correctly documents username/password) and pointed users at a credential type the connector doesn't use.What the docs said:
What the code does: username/password via Flight SQL
Credentials::new(...); no PAT handling.Fix: reworded the row to reference the actual
dremio_username/dremio_passwordcredentials.Source ref
trunk—crates/data-connectors/connector-dremio/src/lib.rs(PARAMETERS= username/password/endpoint;create()buildsCredentials::new(username, password))Test plan
cd website && npm run buildpasses (Docusaurus build succeeded —Generated static files in "build")PATfor Dremio appeared only in vNext +version-2.0.xdeployment.md (the page doesn't exist in older versions); both fixed