Skip to content

Feature/devexp 1324 sms api groups#148

Merged
marcos-sinch merged 22 commits into
v2.1-nextfrom
feature/DEVEXP-1324-sms-api-groups
Jun 5, 2026
Merged

Feature/devexp 1324 sms api groups#148
marcos-sinch merged 22 commits into
v2.1-nextfrom
feature/DEVEXP-1324-sms-api-groups

Conversation

@marcos-sinch
Copy link
Copy Markdown
Contributor

  • Implements all 7 SMS Groups API operations: create, list, get, replace, update, delete, list_members

  • Removes deprecated dataclass-based groups and inbounds stubs (models/groups/, models/inbounds/) predating the v1 Pydantic layer

@JPPortier
Copy link
Copy Markdown

Not related to this PR, but the main branch still contains old groups/inbounds directories: https://github.com/sinch/sinch-sdk-python/tree/main/sinch/domains/sms/models released with 0.1.0 version

Is timing if goo to remove them ?

@marcos-sinch
Copy link
Copy Markdown
Contributor Author

Not related to this PR, but the main branch still contains old groups/inbounds directories: https://github.com/sinch/sinch-sdk-python/tree/main/sinch/domains/sms/models released with 0.1.0 version

Is timing if goo to remove them ?

I see two options: open a dedicated PR on main to remove them now, or wait and include the cleanup in the 2.1.0 release, this files are already removed in this PR. — what do you think?

@JPPortier
Copy link
Copy Markdown

Not related to this PR, but the main branch still contains old groups/inbounds directories: https://github.com/sinch/sinch-sdk-python/tree/main/sinch/domains/sms/models released with 0.1.0 version
Is timing if goo to remove them ?

I see two options: open a dedicated PR on main to remove them now, or wait and include the cleanup in the 2.1.0 release, this files are already removed in this PR. — what do you think?

It is not part of new feature for this PR: can be a different one

Comment thread examples/snippets/sms/groups/create/snippet.py Outdated
Comment thread examples/snippets/sms/groups/create/snippet.py Outdated
Comment thread examples/snippets/sms/groups/get/snippet.py
Comment thread sinch/domains/sms/api/v1/groups.py Outdated
Comment thread sinch/domains/sms/api/v1/groups_apis.py
Comment thread examples/snippets/sms/groups/replace/snippet.py Outdated
Comment thread sinch/domains/sms/models/v1/internal/__init__.py
@marcos-sinch marcos-sinch requested a review from JPPortier June 4, 2026 09:02
Copy link
Copy Markdown

@JPPortier JPPortier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to update too:

  • CHANGELOG about API for Groups is now supported
  • MIGRATION_GUIDE for existing users based onto 1.x SDK version

Comment thread examples/snippets/sms/groups/replace/snippet.py Outdated
@marcos-sinch marcos-sinch requested a review from JPPortier June 5, 2026 11:37
@marcos-sinch marcos-sinch merged commit dc9a3fa into v2.1-next Jun 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants