Feature/devexp 1324 sms api groups#148
Conversation
|
Not related to this PR, but the main branch still contains old groups/inbounds directories: https://github.com/sinch/sinch-sdk-python/tree/main/sinch/domains/sms/models released with 0.1.0 version Is timing if goo to remove them ? |
I see two options: open a dedicated PR on main to remove them now, or wait and include the cleanup in the 2.1.0 release, this files are already removed in this PR. — what do you think? |
It is not part of new feature for this PR: can be a different one |
JPPortier
left a comment
There was a problem hiding this comment.
Do not forget to update too:
- CHANGELOG about API for Groups is now supported
- MIGRATION_GUIDE for existing users based onto 1.x SDK version
Implements all 7 SMS Groups API operations: create, list, get, replace, update, delete, list_members
Removes deprecated dataclass-based groups and inbounds stubs (models/groups/, models/inbounds/) predating the v1 Pydantic layer