Skip to content

Bugfix/fix page size none in sms paginator#144

Merged
marcos-sinch merged 5 commits into
v2.0from
bugfix/fix-page-size-none-in-sms-paginator
May 29, 2026
Merged

Bugfix/fix page size none in sms paginator#144
marcos-sinch merged 5 commits into
v2.0from
bugfix/fix-page-size-none-in-sms-paginator

Conversation

@marcos-sinch
Copy link
Copy Markdown
Contributor

  • fix SmsPaginator when page_size is None

@marcos-sinch marcos-sinch requested a review from matsk-sinch May 29, 2026 08:49
Copy link
Copy Markdown
Contributor

@matsk-sinch matsk-sinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚀 Thank you!

Comment thread tests/unit/test_pagination.py Outdated
Comment thread tests/unit/test_pagination.py
Comment thread sinch/core/pagination.py
Comment thread sinch/core/pagination.py
Comment thread tests/conftest.py
@marcos-sinch marcos-sinch requested a review from asein-sinch May 29, 2026 12:32
Copy link
Copy Markdown
Contributor

@asein-sinch asein-sinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@marcos-sinch marcos-sinch merged commit 4a90010 into v2.0 May 29, 2026
6 checks passed
marcos-sinch added a commit that referenced this pull request Jun 2, 2026
* chore: update version to 2.0.1

* bugfix(sms): fix SmsPaginator extra call
marcos-sinch added a commit that referenced this pull request Jun 2, 2026
commit 1610082
Merge: bd98622 0375263
Author: Marcos Lozano Romero <marcos.lozano01.sinch@gmail.com>
Date:   Tue Jun 2 16:08:27 2026 +0200

    Merge remote-tracking branch 'origin/main' into v2.1-next

commit 0375263
Author: Marcos Lozano Romero <marcos.lozano01.sinch@gmail.com>
Date:   Tue Jun 2 14:51:39 2026 +0200

    Update CHANGELOG for version 2.0.1 (#149)

    Add version 2.0.1 release notes including SMS paginator fix.

commit eecdcd9
Author: Marcos Lozano Romero <marcos.lozano01.sinch@gmail.com>
Date:   Tue Jun 2 14:37:43 2026 +0200

    Bugfix/fix page size none in sms paginator (#144) (#145)

    * chore: update version to 2.0.1

    * bugfix(sms): fix SmsPaginator extra call

commit 81c868b
Author: Marcos Lozano Romero <marcos.lozano01.sinch@gmail.com>
Date:   Wed May 27 17:31:22 2026 +0200

    chore: update readme (#143)

    * chore: update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants