improvement(ui): remove anti-patterns, fix follow-up auto-scroll, move CopyCodeButton to emcn by waleedlatif1 · Pull Request #4148 · simstudioai/sim

waleedlatif1 · 2026-04-14T02:56:17Z

Summary

Fixed suggested follow-ups not scrolling into view after stream ends — added a brief post-stream MutationObserver in use-auto-scroll to catch the DOM expansion
Moved CopyCodeButton from components/ui into components/emcn/components/code, exported from the emcn barrel, nudged slightly right in code block headers
Removed dead code and anti-patterns, ran full cleanup pass

Type of Change

Bug fix

Testing

Tested manually

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…to-scroll, move CopyCodeButton to emcn

vercel · 2026-04-14T02:56:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 14, 2026 4:57am

cursor · 2026-04-14T02:56:27Z

PR Summary

Medium Risk
Touches execution-cancellation paths and adds a DB transaction that updates paused executions and execution logs, so mistakes could incorrectly mark executions as cancelled or impact observability. UI changes are low risk but rely on the new transient cancelling status and optimistic cache updates.

Overview
Execution cancellation now supports paused HITL runs. The cancel API (POST /api/workflows/[id]/executions/[executionId]/cancel) adds a fallback that cancels paused executions directly in the DB via PauseResumeManager.cancelPausedExecution, and emits execution:cancelled metadata/events when that path succeeds; the response now includes pausedCancelled, and server-side tests were expanded to cover auth/403 and this new cancel mode.

Logs UI gets better cancellation feedback. The logs view introduces a cancelling display status and an optimistic React Query update in useCancelExecution to immediately mark the targeted log as cancelling, and the context menu allows cancelling pending executions (not just running).

UI cleanup / component moves. CopyCodeButton is moved under emcn (exported from the barrel) and standardized to use the Button component; various small cleanups remove dead mappings and render/effect anti-patterns, and tooling bumps turbo to 2.9.6.

^{Reviewed by Cursor Bugbot for commit abf4b5a. Configure here.}

greptile-apps · 2026-04-14T03:01:48Z

Greptile Summary

This PR removes anti-patterns, fixes follow-up auto-scroll in the Mothership chat by reverting the streaming guard on onOptionSelect, and relocates CopyCodeButton from components/ui into the emcn library. It also lands several HITL cancellation fixes (DB endedAt, fire-and-forget .catch() guards, and canvas event emission for paused executions) along with a matching test suite update.

Confidence Score: 5/5

Safe to merge — all remaining findings are P2 style suggestions with no correctness impact.
Previous P0/P1 concerns (missing endedAt, uncancellable observer timer, tilde-fence handling) are confirmed resolved. The two remaining findings are a TypeScript any annotation and a missing intermediate query-key factory method — neither affects runtime behaviour.
No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.ts	HITL cancellation route: always attempts DB cancel alongside Redis/local-abort paths and emits canvas event only for the DB-only path. One `error: any` catch-block violates TypeScript rules.
apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.test.ts	Well-structured tests using `vi.hoisted()` + static imports; covers all four cancellation outcomes and auth/authz edge cases cleanly.
apps/sim/hooks/queries/logs.ts	Solid `useCancelExecution` mutation with proper optimistic update, `onError` rollback, and `onSettled` invalidation; one inline stats key prefix deviates from the factory pattern.
apps/sim/components/emcn/components/code/copy-code-button.tsx	Clean move of CopyCodeButton into the emcn library; timer cleanup via ref is correct and the component follows the emcn patterns properly.
apps/sim/app/workspace/[workspaceId]/home/components/mothership-chat/mothership-chat.tsx	Follow-up scroll fix reverted to always passing `onSubmit` for the last message — removes the post-stream DOM expansion that was causing scroll issues. Layout constants extraction is clean.
apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/chat-content/chat-content.tsx	Streaming reveal integration and special-tag rendering are well-structured; `CopyCodeButton` now sourced from emcn correctly.
apps/sim/app/workspace/[workspaceId]/logs/utils.ts	Utility functions properly extracted and documented with TSDoc; `StatusBadge` and `TriggerBadge` use `React.memo` and `displayName` correctly.
apps/sim/lib/workflows/executor/human-in-the-loop-manager.ts	`cancelPausedExecution` now correctly sets `endedAt: now` alongside `status: 'cancelled'`, fixing the running-filter bug flagged in a previous review thread.
apps/sim/lib/core/utils/browser-storage.ts	Well-typed SSR-safe localStorage utilities with proper error handling and structured storage classes for landing-page data.

Sequence Diagram

sequenceDiagram
    participant Client
    participant CancelRoute as POST /cancel
    participant Redis as markExecutionCancelled
    participant LocalAbort as abortManualExecution
    participant DB as cancelPausedExecution
    participant EventBuffer

    Client->>CancelRoute: POST cancel
    CancelRoute->>Redis: markExecutionCancelled(executionId)
    CancelRoute->>LocalAbort: abortManualExecution(executionId)
    CancelRoute->>DB: cancelPausedExecution(executionId)
    Note over DB: Sets status=cancelled, endedAt=now

    alt durablyRecorded
        CancelRoute-->>Client: success (Redis path)
    else locallyAborted
        CancelRoute-->>Client: success (in-process path)
    else pausedCancelled
        CancelRoute->>EventBuffer: setExecutionMeta + write execution:cancelled
        CancelRoute-->>Client: success (DB direct path)
    else none succeeded
        CancelRoute-->>Client: "success=false"
    end

_{Reviews (8): Last reviewed commit: "fix(hitl): add .catch() to fire-and-forg..." | Re-trigger Greptile}

apps/sim/hooks/use-auto-scroll.ts

apps/sim/hooks/use-streaming-reveal.ts

apps/sim/tailwind.config.ts

…p scroll root cause

waleedlatif1 · 2026-04-14T03:24:03Z

@greptile

waleedlatif1 · 2026-04-14T03:24:07Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 77f2b27. Configure here.}

waleedlatif1 · 2026-04-14T03:36:23Z

@greptile

waleedlatif1 · 2026-04-14T03:36:27Z

@cursor review

apps/sim/components/emcn/components/code/copy-code-button.tsx

…y override ghost variant

waleedlatif1 · 2026-04-14T03:49:19Z

@greptile

waleedlatif1 · 2026-04-14T04:01:24Z

@greptile

waleedlatif1 · 2026-04-14T04:01:28Z

@cursor review

Paused HITL executions are idle in the DB — they don't poll Redis or run in-process, so the existing cancel signals had no effect. The DB status stayed 'pending', causing the optimistic 'cancelling' update to revert on refetch. - Add PauseResumeManager.cancelPausedExecution: atomically sets paused_executions.status and workflow_execution_logs.status to 'cancelled' inside a FOR UPDATE transaction - Guard enqueueOrStartResume against resuming a cancelled execution - Include pausedCancelled in the cancel route success check

- Mock PauseResumeManager.cancelPausedExecution to prevent DB calls - Add pausedCancelled to all expected response objects - Add test for HITL paused execution cancellation path - Add missing auth/authz tests - Switch to vi.hoisted pattern for all mocks

waleedlatif1 · 2026-04-14T04:07:44Z

@greptile

waleedlatif1 · 2026-04-14T04:07:49Z

@cursor review

apps/sim/lib/workflows/executor/human-in-the-loop-manager.ts

apps/sim/app/workspace/[workspaceId]/home/home.tsx

Without endedAt, the logs API running filter (isNull(endedAt)) would keep cancelled paused executions in the running view indefinitely.

waleedlatif1 · 2026-04-14T04:19:01Z

@greptile

waleedlatif1 · 2026-04-14T04:19:06Z

@cursor review

apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.ts

…aused execution Paused HITL executions have no active SSE stream, so the canvas never received the cancellation event. Now writes execution:cancelled to the event buffer and updates the stream meta so the canvas reconnect path picks it up and shows 'Execution Cancelled'.

…ellation Wrap cancelPausedExecution in try/catch so a DB error does not mask a prior successful Redis or in-process cancellation. Also move the resource-collapse side effect in home.tsx to a useEffect to avoid the stale closure on the resources array.

waleedlatif1 · 2026-04-14T04:37:52Z

@greptile

waleedlatif1 · 2026-04-14T04:37:56Z

@cursor review

apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.ts

apps/sim/app/workspace/[workspaceId]/logs/utils.ts

…el route

waleedlatif1 · 2026-04-14T04:57:30Z

@greptile

waleedlatif1 · 2026-04-14T04:57:34Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit abf4b5a. Configure here.}

improvement(ui): restore smooth streaming animation, fix follow-up au…

4f98438

…to-scroll, move CopyCodeButton to emcn

waleedlatif1 requested review from Sg312 and icecrasher321 April 14, 2026 02:57

vercel bot deployed to Preview April 14, 2026 02:59 View deployment

greptile-apps bot reviewed Apr 14, 2026

View reviewed changes

apps/sim/hooks/use-auto-scroll.ts Outdated Show resolved Hide resolved

apps/sim/hooks/use-streaming-reveal.ts Outdated Show resolved Hide resolved

cursor bot reviewed Apr 14, 2026

View reviewed changes

apps/sim/tailwind.config.ts Show resolved Hide resolved

fix(ui): restore delayed animation, handle tilde fences, fix follow-u…

aba72b8

…p scroll root cause

vercel bot temporarily deployed to Preview April 14, 2026 03:16 Inactive

fix(ui): extract useStreamingReveal to followup, keep cleanup changes

77f2b27

vercel bot temporarily deployed to Preview April 14, 2026 03:23 Inactive

fix(ui): restore hydratedStreamingRef for reconnect path order-of-ops

c68263f

vercel bot temporarily deployed to Preview April 14, 2026 03:28 Inactive

fix(ui): restore full hydratedStreamingRef effect for reconnect path

0ecd6bd

vercel bot temporarily deployed to Preview April 14, 2026 03:29 Inactive

cursor bot reviewed Apr 14, 2026

View reviewed changes

apps/sim/components/emcn/components/code/copy-code-button.tsx Show resolved Hide resolved

fix(ui): use hover-hover prefix on CopyCodeButton callers to correctl…

335c295

…y override ghost variant

vercel bot temporarily deployed to Preview April 14, 2026 03:44 Inactive

fix(logs): remove destructive color from cancel execution menu item

b6ab71d

vercel bot temporarily deployed to Preview April 14, 2026 03:46 Inactive

feat(logs): optimistic cancelling status on cancel execution

03f6e74

vercel bot temporarily deployed to Preview April 14, 2026 03:48 Inactive

waleedlatif1 added 2 commits April 13, 2026 21:01

upgrade turbo

394be59

vercel bot deployed to Preview April 14, 2026 04:05 View deployment

vercel bot temporarily deployed to Preview April 14, 2026 04:06 Inactive

greptile-apps bot reviewed Apr 14, 2026

View reviewed changes

apps/sim/lib/workflows/executor/human-in-the-loop-manager.ts Show resolved Hide resolved

cursor bot reviewed Apr 14, 2026

View reviewed changes

apps/sim/app/workspace/[workspaceId]/home/home.tsx Outdated Show resolved Hide resolved

fix(hitl): set endedAt when cancelling paused execution

85d9fd6

Without endedAt, the logs API running filter (isNull(endedAt)) would keep cancelled paused executions in the running view indefinitely.

vercel bot temporarily deployed to Preview April 14, 2026 04:13 Inactive

cursor bot reviewed Apr 14, 2026

View reviewed changes

apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.ts Outdated Show resolved Hide resolved

vercel bot temporarily deployed to Preview April 14, 2026 04:28 Inactive

vercel bot temporarily deployed to Preview April 14, 2026 04:30 Inactive

cursor bot reviewed Apr 14, 2026

View reviewed changes

apps/sim/app/api/workflows/[id]/executions/[executionId]/cancel/route.ts Show resolved Hide resolved

apps/sim/app/workspace/[workspaceId]/logs/utils.ts Show resolved Hide resolved

fix(hitl): add .catch() to fire-and-forget event buffer calls in canc…

abf4b5a

…el route

vercel bot temporarily deployed to Preview April 14, 2026 04:57 Inactive

cursor bot reviewed Apr 14, 2026

View reviewed changes

waleedlatif1 merged commit 9c1b0bc into staging Apr 14, 2026
14 checks passed

waleedlatif1 deleted the fix/resource-url branch April 14, 2026 05:04

Conversation

waleedlatif1 commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

waleedlatif1 commented Apr 14, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented Apr 14, 2026 •

edited

Loading

vercel bot commented Apr 14, 2026 •

edited

Loading

cursor bot commented Apr 14, 2026 •

edited

Loading

greptile-apps bot commented Apr 14, 2026 •

edited

Loading