Remove annimon stream part4#14719
Open
JesseWeinstein wants to merge 39 commits intosignalapp:mainfrom
Open
Conversation
* Converted Stream.of to .stream()) * Inverted .filterNot * Replaced .toList with .collect(Collectors.toList()) Fixes signalapp#14700
* Converted Stream.of to .stream())
* Replaced .toList with .collect(Collectors.toList())
* Converted non-array calls to Stream.of to .stream())
* Converted non-array calls to Stream.of to .stream()) * Inverted .filterNot * Replaced .toList with .collect(Collectors.toList())
* Inverted .filterNot
* Converted Stream.of to .stream()) * Inverted .filterNot * Replaced .toList with .collect(Collectors.toList())
* Converted Stream.of to .stream())
…since it does weird things with differing types
This needed to be done separately, due to the use of Stream.concat
and use it in two straightforward places
…ed by combining two streams This should be looked at carefully.
(one of which wasn't needed) Should be looked at carefully
Should be looked at carefully.
Should be looked at carefully. It previously would throw NoSuchElementException if there weren't any public keys, now it will throw IllegalStateException. This shouldn't matter.
(and convert the rest of those files)
jeffrey-signal
approved these changes
Apr 14, 2026
Contributor
jeffrey-signal
left a comment
jeffrey-signal
left a comment
There was a problem hiding this comment.
Thanks! Will be in 8.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntaxDescription
This should only be reviewed once #14718 is merged.
This splits up the
Stream.ofcalls between the array uses and the Collection uses, then converts them both. Then removes the library.It touches a bunch of files, but it's pretty straightforward.
I can break it up further if desired.