Skip to content

fix: correct false negative for BoardGameGeek (#2803)#2918

Open
victoireantoine1707-design wants to merge 1 commit intosherlock-project:masterfrom
victoireantoine1707-design:fix/false-negative-boardgamegeek
Open

fix: correct false negative for BoardGameGeek (#2803)#2918
victoireantoine1707-design wants to merge 1 commit intosherlock-project:masterfrom
victoireantoine1707-design:fix/false-negative-boardgamegeek

Conversation

@victoireantoine1707-design
Copy link
Copy Markdown

@victoireantoine1707-design victoireantoine1707-design commented Apr 26, 2026

Issue #2803

Sherlock fails to detect existing BoardGameGeek profiles
The errorMsg was inverted: the API returns {"isValid":true} when a username
is AVAILABLE, and {"isValid":false} when it is TAKEN (i.e. user exists)

Solution proposed
Changed errorMsg from "isValid":true to "isValid":false to correctly
detect existing profiles

Verification done
Manually verified via API:

@github-actions
Copy link
Copy Markdown
Contributor

Automatic validation of changes

Target F+ Check F- Check
BoardGameGeek ❌   Fail ❌   Fail

Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants