Skip to content

Notice callback drop timing in add_route #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdm merged 2 commits into from
Jan 2, 2026
Merged

Notice callback drop timing in add_route #431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5f8add
Notice callback drop timing in `add_route`
Legend-Master Jan 2, 2026
c210a6e
Apply suggestion from code review
Legend-Master Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/router.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ impl RouterProxy {

/// Add a new (receiver, callback) pair to the router, and send a wakeup message
/// to the router.
///
/// The `callback` is dropped when `receiver`'s channel disconnects.
fn add_route(&self, receiver: OpaqueIpcReceiver, callback: RouterHandler) {
let comm = self.comm.lock().unwrap();

Expand All @@ -83,6 +85,8 @@ impl RouterProxy {

/// Add a new `(receiver, callback)` pair to the router, and send a wakeup message
/// to the router.
///
/// The `callback` is dropped when `receiver`'s channel disconnects.
pub fn add_typed_route<T>(
&self,
receiver: IpcReceiver<T>,
Expand Down