Expose a way to manually set BOOTSTRAP_PREFIX#426
Merged
jdm merged 1 commit intoservo:mainfrom Nov 20, 2025
ChristianBelloni:main
Merged
Expose a way to manually set BOOTSTRAP_PREFIX#426jdm merged 1 commit intoservo:mainfrom ChristianBelloni:main
jdm merged 1 commit intoservo:mainfrom
ChristianBelloni:main
Conversation
jdm
approved these changes
Nov 20, 2025
Member
jdm
left a comment
jdm
left a comment
There was a problem hiding this comment.
This seems like a reasonable way to support this.
Contributor
Author
|
Awesome! thanks for the swift reply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to use this library in a sandboxed environment the prefix has to adhere to a specific format, here's a link to a relevant SO discussion
I have no idea what would be the ideal approach to correctly expose the bootstrap prefix, in this pr it's basically slapped on in lib.rs, if this is a use case that you'd like to support let me know any changes needed to merge