Switch to serde_core#419
Merged
jdm merged 1 commit intoservo:mainfrom Sep 27, 2025
Merged
Conversation
Member
|
Nice, happy to merge this once CI is fixed. |
Narfinger
force-pushed
the
serde_core
branch
from
d359ca8 to
dbe30dc
Compare
Contributor
Author
|
Ok let's see what the CI says now. |
serde_derive. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Narfinger
force-pushed
the
serde_core
branch
from
dbe30dc to
955cf04
Compare
jdm
approved these changes
Sep 27, 2025
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
@jdm: a heads up: I had to revert this in the multiplexing prototype (which derives Serialize and Deserialize). This is awkward as it's the first real interaction of the prototype with the rest of the code and could increase rebase friction from now on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serde_core allows crates that depend on this and serde_derive to compile both of them in paralell.
Signed-off-by: Narfinger Narfinger@users.noreply.github.com