Remove PartialEq from OsIpcSender and OsIpcReceiver#416
Merged
jschwe merged 2 commits intoservo:mainfrom Dec 18, 2025
Merged
Conversation
jschwe
force-pushed
the
remove_partialeq
branch
2 times, most recently
from
1109d6f to
860f740
Compare
jschwe
changed the title
jschwe
force-pushed
the
remove_partialeq
branch
from
860f740 to
92a8b7e
Compare
sagudev
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing channels for equality can be tricky, and was previously wrong for the in-process backend.
The only usage was in our tests and can be removed by writing the assert differently.
Fixes #414