chore: Fix clippy warning on force-inprocess feature#411
Merged
mrobinson merged 4 commits intoservo:mainfrom Aug 19, 2025
Merged
chore: Fix clippy warning on force-inprocess feature#411mrobinson merged 4 commits intoservo:mainfrom
force-inprocess feature#411mrobinson merged 4 commits intoservo:mainfrom
Conversation
Signed-off-by: Jerens Lensun <jerensslensun@gmail.com>
Signed-off-by: Jerens Lensun <jerensslensun@gmail.com>
…-error-on-force-inprocess-features
mrobinson
requested changes
Aug 19, 2025
| } | ||
|
|
||
| impl OsIpcSharedMemory { | ||
| /// # Safety |
Member
There was a problem hiding this comment.
You will need to fill out the Safety comment here or ask clippy to ignore the error.
@sagudev I think you created this function. Do you mind writing a small explanation for why it is unsafe.
Member
There was a problem hiding this comment.
Signed-off-by: Jerens Lensun <jerensslensun@gmail.com>
mrobinson
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the linting error when running clippy on
force-inprocessfeature