Skip to content

Keep all information from denite when adding icon#229

Merged
ryanoasis merged 1 commit intoryanoasis:masterfrom
carlitux:master
Mar 10, 2018
Merged

Keep all information from denite when adding icon#229
ryanoasis merged 1 commit intoryanoasis:masterfrom
carlitux:master

Conversation

@carlitux
Copy link
Copy Markdown
Contributor

@carlitux carlitux commented Feb 19, 2018

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

How should this be manually tested?

Enable denite and list buffers, file_mru, directory_mru, those are new features

What are the relevant tickets (if any)?

#216

@ryanoasis ryanoasis added this to the v0.11.0 milestone Feb 19, 2018
@ryanoasis
Copy link
Copy Markdown
Owner

ryanoasis commented Feb 19, 2018

@carlitux Awesome, thanks for this! 👍

I see you also added some additional sources

@maxnordlund
Copy link
Copy Markdown

I noticed all tabs has been converted to spaces, which makes at least me a bit confused as to what has actually changed.

But maybe it's not really important in the end.

@ryanoasis
Copy link
Copy Markdown
Owner

@maxnordlund Yeah that's a good point/catch.

@carlitux Could you amend your commit and revert the purely indentation changes? That way it is a little easier to diff the changes.

* Solve this issue ryanoasis#216
* Update sources to process
@carlitux
Copy link
Copy Markdown
Contributor Author

@ryanoasis done.

Just a comment, would be good to add a .editorconfig to use that setup.

@maxnordlund
Copy link
Copy Markdown

A .editorconfig is a great idea

@ryanoasis
Copy link
Copy Markdown
Owner

Thanks. Good idea, we should add that.

I think there is not consistency between the files but there should be!

@ryanoasis ryanoasis merged commit d9a8fef into ryanoasis:master Mar 10, 2018
@ryanoasis
Copy link
Copy Markdown
Owner

Looks good to me ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants