Keep all information from denite when adding icon#229
Merged
ryanoasis merged 1 commit intoryanoasis:masterfrom Mar 10, 2018
Merged
Keep all information from denite when adding icon#229ryanoasis merged 1 commit intoryanoasis:masterfrom
ryanoasis merged 1 commit intoryanoasis:masterfrom
Conversation
Owner
|
@carlitux Awesome, thanks for this! 👍 I see you also added some additional sources |
|
I noticed all tabs has been converted to spaces, which makes at least me a bit confused as to what has actually changed. But maybe it's not really important in the end. |
Owner
|
@maxnordlund Yeah that's a good point/catch. @carlitux Could you amend your commit and revert the purely indentation changes? That way it is a little easier to diff the changes. |
* Solve this issue ryanoasis#216 * Update sources to process
Contributor
Author
|
@ryanoasis done. Just a comment, would be good to add a .editorconfig to use that setup. |
|
A .editorconfig is a great idea |
Owner
|
Thanks. Good idea, we should add that. I think there is not consistency between the files but there should be! |
Owner
|
Looks good to me ❤️ |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements (please check off with 'x')
What does this Pull Request (PR) do?
How should this be manually tested?
Enable denite and list buffers, file_mru, directory_mru, those are new features
What are the relevant tickets (if any)?
#216