Skip to content

Add tsx#210

Merged
ryanoasis merged 1 commit intoryanoasis:masterfrom
dustinblackman:master
Oct 13, 2017
Merged

Add tsx#210
ryanoasis merged 1 commit intoryanoasis:masterfrom
dustinblackman:master

Conversation

@dustinblackman
Copy link
Copy Markdown
Contributor

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

Add an icon for .tsx, copying the one from .jsx.

How should this be manually tested?

Create a .tsx file, load NERDTree, profit.

Any background context you can provide?

There is no .tsx icon set at the moment so it adds the React logo just like .jsx.

Screenshots (if appropriate or helpful)

screen shot 2017-07-28 at 9 30 52 am

@ryanoasis
Copy link
Copy Markdown
Owner

Create a .tsx file, load NERDTree, profit.

Right on 😉 thanks

@ryanoasis ryanoasis added this to the v0.9.3 milestone Jul 28, 2017
@dustinblackman
Copy link
Copy Markdown
Contributor Author

@ryanoasis Still plan on merging this?

@ryanoasis
Copy link
Copy Markdown
Owner

@dustinblackman Yes for sure. Sorry for the delay. I've been busy traveling. I'll be back Monday and next week I'll cobble together a release 😊

@ryanoasis ryanoasis merged commit e60bc98 into ryanoasis:master Oct 13, 2017
@ryanoasis
Copy link
Copy Markdown
Owner

Thanks for the patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants