Skip to content

Added notes informing the user to make sure other vim plugins are up …#177

Merged
ryanoasis merged 2 commits intoryanoasis:masterfrom
Melon-Bread:master
Oct 24, 2016
Merged

Added notes informing the user to make sure other vim plugins are up …#177
ryanoasis merged 2 commits intoryanoasis:masterfrom
Melon-Bread:master

Conversation

@Melon-Bread
Copy link
Copy Markdown
Contributor

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

Informs the user that if NERDTree and/or Ctrlp are not up to date they will receive error.

How should this be manually tested?

I am not sure this PR applies. Although I can reword or place the info in a different section if needed.

Any background context you can provide?

#174

What are the relevant tickets (if any)?

#176

Screenshots (if appropriate or helpful)

Markdown Preview

Notes

I am very new to submitting pull requests especially to bigger projects such as this. So, if I messed up at any point let me know so I can fix my mistake.

…to date

@ryanoasis
Copy link
Copy Markdown
Owner

I am not sure this PR applies. Although I can reword or place the info in a different section if needed.

Sure and actually changing readmes can be a bit challenging because it's a bit more subjective right?

I am very new to submitting pull requests especially to bigger projects such as this. So, if I messed up at any point let me know so I can fix my mistake.

Sure no problem at all. I will let you know. I try to make sure to stay friendly and I don't tolerate any less on this project but to be a friendly positive place 😄


So here is some feedback:

  • you have small typo/spelling error: "recieve"
  • both lines should mention the outdated message warnings and ability to show icons
  • the reason for the messages is that these plugins have out of date versions on vim.org:
    • ctrlp
    • NERDTree
    • ^ I would like a link to each of these preferably

I think that would be good for now and if anything else it will probably just get tweaked later on 😄

- Fixed spelling error
- Linked to outdated version of each plugin
- Identified the issue and the outcome for each plugin
@Melon-Bread
Copy link
Copy Markdown
Contributor Author

I committed the changes trying my best to include what you mentioned in your message above. If there is anything else you want want me to tweak just let me know. (Your response was very positive, friendly, and all around informative. Thank you very much!) 👍

@ryanoasis
Copy link
Copy Markdown
Owner

@Melon-Bread Looks good to me. Thanks.

No problem, I have been on the other side and just don't see any reason for the negativity. I try to accept all PRs and make sure things stay helpful and positive

@ryanoasis ryanoasis merged commit cc221aa into ryanoasis:master Oct 24, 2016
@ryanoasis ryanoasis modified the milestone: v0.8.6 Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants