Skip to content

add reference to tiagofumo/vim-nerdtree-syntax-highlight on readme#161

Merged
ryanoasis merged 1 commit intoryanoasis:masterfrom
tiagofumo:master
Jul 23, 2016
Merged

add reference to tiagofumo/vim-nerdtree-syntax-highlight on readme#161
ryanoasis merged 1 commit intoryanoasis:masterfrom
tiagofumo:master

Conversation

@tiagofumo
Copy link
Copy Markdown
Contributor

@tiagofumo tiagofumo commented Jul 20, 2016

Requirements (please check off with 'x')

What does this Pull Request (PR) do?

adds reference to tiagofumo/vim-nerdtree-syntax-highlight on readme as talked with @ryanoasis on gitter

How should this be manually tested?

it's a readme file

Any background context you can provide?

I created this extension in another repo (because I thought I was going to be the only human being using it) and some people started caring about it, so I asked @ryanoasis if I should add reference to it on the readme's section and he said yes

What are the relevant tickets (if any)?

#158 (comment)

Screenshots (if appropriate or helpful)

it's possible to see the output on my fork's page: https://github.com/tiagofumo/vim-devicons

@ryanoasis ryanoasis modified the milestone: v0.8.4 Jul 23, 2016
@ryanoasis ryanoasis merged commit 199e07f into ryanoasis:master Jul 23, 2016
@ryanoasis
Copy link
Copy Markdown
Owner

@tiagofumo This was merged however the readme has changed drastically in v0.8.4 which part of those changes include offloading the FAQ to the wiki

Nevertheless I merged your change so you do get the credit and I replicated the same change you made to the wiki FAQ as well as mentioning the plugin in the changelog and release notes

@tiagofumo
Copy link
Copy Markdown
Contributor Author

tiagofumo commented Jul 24, 2016

@ryanoasis thanks a lot man, I appreciate it 😃 . Sorry for the inconvenience.

@ryanoasis
Copy link
Copy Markdown
Owner

@tiagofumo no problem! No inconvenience at all no worries 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants