Add LogicalPoint, PhysicalPoint and Point

[amrbashir]

part of #2395

• Tested on all platforms changed
• Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
• Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
• Created or updated an example program if it would help users understand this functionality
• Updated feature matrix, if new features were added or implemented

[daxpedda]

Looking at #2395 I don't really follow what the motivation here is exactly.
Is there some previous related discussion?

[amrbashir]

#2395 is not implemented in winit (yet?) but already implemented in tao here and the idea is to be able to only constraint the min-width while keeping other window dimensions unconstrainted.

Once this new dpi crate is published, we can use it not only in tao but in a number of other crates we have along with the main tauri crate itself. This PR is a blocker for tao only not other crates

[daxpedda]

My question is specifically how does Logical/PhysicalPoint relate to that? Why can that not be done with the types we have now?

[amrbashir]

Because the existing types require setting both width/height, and so you can't say I want to constraint only width or only height.

[daxpedda]

Ah, I see, thank you!

[kchibisov]

Should probably update the docs in ### Position and Size types with the point stuff.

[kchibisov]

Besides.

@amrbashir given that you had an interest in such crate in the first place, how you deal with e.g. rounding? For example in winit we have special rounding rules on Wayland, because it's rounding is a bit special, but maybe we should define such things in this crate as well, so the to_logical/to_physical will account for rounding and make the default like it was before?

[amrbashir]

We didn't give it much thought, since our windows and macOS backend were forked from winit and the current behavior of to_logical/to_physical have been working fine for us.

[amrbashir]

I just realized that the naming Point might be confusing when used with width/height as it conveys position than a dimension, maybe it should be renamed to LogicalUnit, PhysicalUnit and Unit or PixelUnit ?

[kchibisov]

I just realized that the naming Point might be confusing when used with width/height as it conveys position than a dimension, maybe it should be renamed to LogicalUnit, PhysicalUnit and Unit or PixelUnit ?

Maybe LogicalUnit/PhysicalUnit is better.

[kchibisov]

Thanks