[beta] backport fix for #40951#41269
Closed
nikomatsakis wants to merge 3 commits into
Closed
Conversation
In some cases, we give multiple primary spans, in which case we would report one `//~` annotation per primary span. That was very confusing because these things are reported to the user as a single error. UI tests would be better here.
Contributor
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
|
Contributor
Author
nikomatsakis
added
beta-nominated
Contributor
Member
|
r=me if the compiler team is good with this |
Contributor
Author
I also have mixed feelings. |
Contributor
Author
|
We discussed this in the @rust-lang/compiler meeting and decided not to backport. This change is a bit more complex than we are comfortable with, and the fallout seems quite minimal. The regression is fixed on nightly. |
nikomatsakis
removed
the
beta-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @arielb1 -- this is a backport of just the fix needed for #40951. Thoughts?