keep the AST node-id when lowering ExprKind::Range#40764
Merged
Conversation
When the Range expression is the root of a constant, its node-id is used for the def-id of the body, so it has to be preserved in the AST -> HIR lowering. Fixes rust-lang#40749.
arielb1
added
the
beta-nominated
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 8ffe406 has been approved by |
nikomatsakis
added
the
beta-accepted
Contributor
|
Marking as beta-accepted. Small patch, regression. cc @rust-lang/compiler |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 25, 2017
keep the AST node-id when lowering ExprKind::Range When the Range expression is the root of a constant, its node-id is used for the def-id of the body, so it has to be preserved in the AST -> HIR lowering. Fixes rust-lang#40749. r? @eddyb beta-nominating because regression
Collaborator
|
⌛ Testing commit 8ffe406 with merge 4e9953d... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
Author
Collaborator
|
⌛ Testing commit 8ffe406 with merge 3e8c572... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
Author
Collaborator
|
⌛ Testing commit 8ffe406 with merge ccce2c6... |
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Member
|
@arielb1 unfortunately this doesn't apply cleanly to the beta branch, would you mind looking into the backport? |
Merged
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
[beta] Beta next - rust-lang#40764 - rust-lang#40809 - rust-lang#41015 r? @brson
alexcrichton
removed
the
beta-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Range expression is the root of a constant, its node-id is
used for the def-id of the body, so it has to be preserved in the AST ->
HIR lowering.
Fixes #40749.
r? @eddyb
beta-nominating because regression