Markdown cleanup#40309
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks! @bors: r+ |
|
📌 Commit 474814f has been approved by |
|
@bors: r- Just noticed that there's a Travis failure that looks legit. |
|
Goofed on a line of markdown, everything seems to be okay now. |
* Make sure std docs are generated before compiler docs so rustdoc uses relative links. * Don't document the rustc and rustdoc binary crates as they overwrite the real rustc and rustdoc crates.
Use the same step names as the actual build.
The generates HTML can contain quotes so we need to make sure they are escaped before inserting into the js files.
|
☔ The latest upstream changes (presumably #39770) made this pull request unmergeable. Please resolve the merge conflicts. |
It may not exist, so we don't want to spuriously generate an error.
consistency (80-character limit).
|
I opted for the version of the configure script in #39770 without any of my own edits. |
rustbuild: Fix compiler docs * Make sure std docs are generated before compiler docs so rustdoc uses relative links. * Don't document the rustc and rustdoc binary crates as they overwrite the real rustc and rustdoc crates. Fixes #40217 r? @alexcrichton
|
Thanks! @bors r+ rollup |
|
📌 Commit 295df14 has been approved by |
|
⌛ Testing commit 295df14 with merge 300d701... |
|
💔 Test failed - status-travis |
Fix a typo in Rev iterator docs r? @GuillaumeGomez
rustdoc: Fix string escaping in implementors js files The generated HTML can contain quotes so we need to make sure they are escaped before inserting into the js files.
|
@bors retry |
rustbuild: Add option for enabling partial LLVM rebuilds @alexcrichton , you probably didn't notice my [late comment](#40236 (comment)) on #40236, but here's an implementation of that suggestion, it supersedes c652a4f. r? @alexcrichton
9 participants
Fixed a couple of grammatical issues and tweaked line endings (most of the documents seem to be going for line length <= 80, so I tweaked a few things to match that).