Translate shims using MIR#39628
Conversation
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
☔ The latest upstream changes (presumably #39586) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Hi @arielb1, |
|
Some functions in Rust, such as enum variant constructions (e.g. |
|
cc @rust-lang/compiler |
|
@arielb1 to what end? what you're doing and why you're doing it are equally important. Your commit messages don't provide information on your rationale 🙁 |
|
@mrhota less special-casing and less convoluted code in the compiler |
|
It also pulls trans-specific code out into MIR in a way that will work for alternative backends (e.g. miri, mir2wasm), reducing duplication between them. |
There was a problem hiding this comment.
A more explicit comment would be nice -- It's not clear to me what the Ty<'tcx> represents here.
|
☔ The latest upstream changes (presumably #40091) made this pull request unmergeable. Please resolve the merge conflicts. |
arielb1
force-pushed
the
shimmir
branch
2 times, most recently
from
f52b583 to
6f607d6
Compare
There was a problem hiding this comment.
Why is this file not in librustc_mir/transform?
There was a problem hiding this comment.
Because it's not a MIR pass.
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
LGTM so far! r=me with those extra FIXMEs if you want to land it like this
There was a problem hiding this comment.
Can you put a FIXME on these to eventually integrate them better with the rest of on-demand?
There was a problem hiding this comment.
But if you have a dep_node method, you can use it to move this to on-demand.
arielb1
force-pushed
the
shimmir
branch
2 times, most recently
from
7d069ec to
bd92573
Compare
|
☔ The latest upstream changes (presumably #39648) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Now ready (except for cleanup, and I prefer to land it now given that this PR is rather big enough already). r? @eddyb |
arielb1
force-pushed
the
shimmir
branch
3 times, most recently
from
040f333 to
9f5def1
Compare
|
I can't see the end of that appveyor log. |
|
sccache failure @bors retry |
|
⌛ Testing commit 5dc8548 with merge 35617fc... |
|
💔 Test failed - status-appveyor |
|
⌛ Testing commit 5dc8548 with merge 0b1ddef... |
|
Mac builders offline @bors retry |
|
⌛ Testing commit 5dc8548 with merge 5e30f81... |
|
💔 Test failed - status-travis |
Translate shims using MIR This removes one large remaining part of old trans.
|
Mac test timeout? @bors retry |
|
☀️ Test successful - status-appveyor, status-travis |
10 participants
This removes one large remaining part of old trans.