Skip to content

Add missing urls and small nits#39513

Closed
GuillaumeGomez wants to merge 1 commit into
rust-lang:masterfrom
GuillaumeGomez:collections_doc
Closed

Add missing urls and small nits#39513
GuillaumeGomez wants to merge 1 commit into
rust-lang:masterfrom
GuillaumeGomez:collections_doc

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Feb 4, 2017

Copy link
Copy Markdown
Member

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez

Copy link
Copy Markdown
Member Author

r? @frewsxcv

@rust-highfive rust-highfive assigned frewsxcv and unassigned sfackler Feb 4, 2017

@frewsxcv frewsxcv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+ rollup

@frewsxcv

frewsxcv commented Feb 4, 2017

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Feb 4, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 5fb89bc has been approved by frewsxcv

@frewsxcv

frewsxcv commented Feb 4, 2017

Copy link
Copy Markdown
Contributor

@bors r-

Linkcheck (x86_64-unknown-linux-gnu)

std/collections/struct.VecDeque.html:301: broken link - std/collections/struct.Drain.html

std/collections/vec_deque/struct.VecDeque.html:147: broken link - std/std/primitive.usize.html

std/collections/vec_deque/struct.VecDeque.html:302: broken link - std/std/mem/fn.forget.html

std/collections/vec_deque/struct.VecDeque.html:347: broken link - std/std/option/enum.Option.html

std/collections/vec_deque/struct.VecDeque.html:361: broken link - std/std/option/enum.Option.html

std/collections/vec_deque/struct.VecDeque.html:379: broken link - std/std/option/enum.Option.html

std/collections/vec_deque/struct.VecDeque.html:393: broken link - std/std/option/enum.Option.html

std/collections/vec_deque/struct.VecDeque.html:411: broken link - std/std/option/enum.Option.html

std/collections/vec_deque/struct.VecDeque.html:448: broken link - std/std/option/enum.Option.html

std/collections/vec_deque/struct.VecDeque.html:466: broken link - std/std/option/enum.Option.html

std/collections/vec_deque/struct.VecDeque.html:489: broken link - std/std/option/enum.Option.html

std/collections/vec_deque/struct.VecDeque.html:531: broken link - std/std/option/enum.Option.html

std/collections/vec_deque/struct.VecDeque.html:572: broken link - std/std/primitive.usize.html

thread 'main' panicked at 'found some broken links', /checkout/src/tools/linkchecker/main.rs:49

@GuillaumeGomez GuillaumeGomez force-pushed the collections_doc branch 2 times, most recently from 5c57475 to 226be6b Compare February 4, 2017 13:43
@GuillaumeGomez

Copy link
Copy Markdown
Member Author

Updated.

@GuillaumeGomez

Copy link
Copy Markdown
Member Author

Strange, it works when tested with the generated docs...

@frewsxcv

Copy link
Copy Markdown
Contributor

It's probably because the docs are generated in two places. The collections crate and std::collections.

@GuillaumeGomez

Copy link
Copy Markdown
Member Author

Makes sense. So I guess we're stuck in here. I'll try to solve this issue later on.

@frewsxcv frewsxcv removed their assignment Feb 25, 2017
@bors

bors commented Mar 23, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #40748) made this pull request unmergeable. Please resolve the merge conflicts.

@steveklabnik

Copy link
Copy Markdown
Contributor

Let's give this one a close, since it's old and has problems. Thanks @GuillaumeGomez !

@GuillaumeGomez GuillaumeGomez deleted the collections_doc branch November 24, 2017 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants