[LLVM 4.0] Update rustllvm to understand the new DIBulder::createBasicType API#38294
Closed
dylanmckay wants to merge 1 commit into
Closed
[LLVM 4.0] Update rustllvm to understand the new DIBulder::createBasicType API#38294dylanmckay wants to merge 1 commit into
dylanmckay wants to merge 1 commit into
Conversation
This lets Rust work with the createBasicType API in LLVM 4.0. The alignment argument was dropped in D25073. - https://reviews.llvm.org/D25073
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
This will bring us closer to upgrading to LLVM 4.0 in #37609 |
dylanmckay
changed the title
Member
|
@bors: r+ |
Collaborator
|
📌 Commit f65552f has been approved by |
Member
|
FWIW, I was trying to move the alignment argument: avr-rust@350ff59
|
Contributor
Author
|
@shepmaster I didn't notice that commit earlier! That's a much better solution. I'll close this PR. |
Member
|
Opened #38317 with that commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets Rust work with the createBasicType API in LLVM 4.0.
The alignment argument was dropped in D25073.