Implement RFC #1245 : unsafe const fn#28827
Merged
Merged
Conversation
Contributor
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
Feel free to hold off on this until the amendment is merged. |
Contributor
Author
|
Just for reference (and linking the issues), this is an implementation of rust-lang/rfcs#1245 |
Contributor
Collaborator
bors
added a commit
that referenced
this pull request
Oct 13, 2015
This is the original test implementation, which works according to the tests I wrote, but might need a review.
Member
|
@bors: retry force |
Collaborator
|
⌛ Testing commit 4c88bf2 with merge 9ea0065... |
Collaborator
|
⛄ The build was interrupted to prioritize another pull request. |
Collaborator
bors
added a commit
that referenced
this pull request
Oct 14, 2015
This is the original test implementation, which works according to the tests I wrote, but might need a review.
Collaborator
Contributor
|
What about the order? In rust-lang/rfcs#1245 the order was set to |
Contributor
Author
|
Huh... implements the RFC as merged, but yes, @aturon's comment did state the other ordering. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the original test implementation, which works according to the tests I wrote, but might need a review.