note which target a missing target_feature belongs to#157594
Merged
rust-bors[bot] merged 1 commit intoJun 13, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @adwinwhite rustbot has assigned @adwinwhite. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
rohaquinlop
changed the title
rohaquinlop
force-pushed
the
issue-109531-diagnostic-improvements
branch
2 times, most recently
from
b0a744f to
777b941
Compare
folkertdev
requested changes
Jun 8, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
When #[target_feature(enable = "sse2")] is used on an aarch64 target, the error now includes a note naming the target architecture where the feature IS valid, e.g.: = note: `sse2` is present on the `x86` target architecture. Did you mean to compile for that target, or use conditional compilation? Multi-arch features (e.g. aes on arm+aarch64+x86) get the plural form listing all matching architectures.
rohaquinlop
force-pushed
the
issue-109531-diagnostic-improvements
branch
from
777b941 to
349075b
Compare
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Contributor
Author
|
r? |
Collaborator
|
Error: Parsing assign command in comment failed: specify user to assign to (if you want to reroll without a specific reviewer in mind, use Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
Contributor
|
r? me |
Contributor
|
Thanks! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 13, 2026
Rollup of 10 pull requests Successful merges: - #157714 (Improve polymorphization of raw pointer formatting) - #157653 (remove AliasTerm::def_id()) - #157773 (Remove AnonConstKind::GCA and reject generic anon consts) - #157846 (Avoid ICE in unconstrained generic parameter suggestion for enums) - #157594 (note which target a missing target_feature belongs to) - #157740 (rustdoc: correct doctest span for trailing semicolon after item) - #157782 (Added `PhantomPinned` diagnostic item and prevented dead field warning on `PhantomPinned`) - #157802 (Ensure that optimize attributes on closures are inherited by the shim.) - #157812 (rustc_public: implement `ty::Alias` conversion) - #157833 (Update wasm-component-ld to 0.5.25)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 13, 2026
Rollup of 10 pull requests Successful merges: - #157714 (Improve polymorphization of raw pointer formatting) - #157653 (remove AliasTerm::def_id()) - #157773 (Remove AnonConstKind::GCA and reject generic anon consts) - #157846 (Avoid ICE in unconstrained generic parameter suggestion for enums) - #157594 (note which target a missing target_feature belongs to) - #157740 (rustdoc: correct doctest span for trailing semicolon after item) - #157782 (Added `PhantomPinned` diagnostic item and prevented dead field warning on `PhantomPinned`) - #157802 (Ensure that optimize attributes on closures are inherited by the shim.) - #157812 (rustc_public: implement `ty::Alias` conversion) - #157833 (Update wasm-component-ld to 0.5.25)
rust-timer
added a commit
that referenced
this pull request
Jun 13, 2026
Rollup merge of #157594 - rohaquinlop:issue-109531-diagnostic-improvements, r=folkertdev note which target a missing target_feature belongs to This PR attempts to improve diagnostics for invalid `target_feature` error, many years ago I experienced that [error](#108680 (comment)) Closes: #109531
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve diagnostics for invalid
target_featureerror, many years ago I experienced that errorCloses: #109531