fix improper ctypes in Znext solver by rajgandhi1 · Pull Request #156399 · rust-lang/rust

rajgandhi1 · 2026-05-10T15:19:13Z

rustbot · 2026-05-10T15:19:18Z

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 18 candidates

Kivooeo · 2026-05-10T23:49:40Z

cc @lcnr

JohnTitor · 2026-05-13T22:07:30Z

r? lcnr

rustbot · 2026-06-05T10:11:15Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2026-06-08T09:18:55Z

                help: None,
            },

+            // Reachable when the new solver reveals a body's defining opaque.


same

View changes since the review

same as above. should I add comments to highlight this?

jdonszelmann · 2026-06-08T09:22:48Z

@rustbot author

rustbot · 2026-06-08T09:22:53Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rajgandhi1 · 2026-06-08T10:28:01Z

@rustbot ready

jdonszelmann · 2026-06-08T10:37:30Z

@rustbot author

…jdonszelmann fix improper ctypes in Znext solver Fixes rust-lang#156352.

Rollup of 3 pull requests Successful merges: - #157503 (Disable `tests/debuginfo/pretty-std.rs` `OsString` cdb check) - #156399 (fix improper ctypes in Znext solver) - #157605 (Arg splat experiment - syntax impl)

…jdonszelmann fix improper ctypes in Znext solver Fixes rust-lang#156352.

Rollup of 10 pull requests Successful merges: - #157335 (bootstrap: Handle dotted table keys when parsing bootstrap.toml) - #157503 (Disable `tests/debuginfo/pretty-std.rs` `OsString` cdb check) - #148183 (rustdoc: Test & document `test_harness` code block attribute) - #156067 (Fix async drop glue for Box<T>) - #156399 (fix improper ctypes in Znext solver) - #157410 (Implement rustc_public::CrateDef{,Type} for FieldDef) - #157605 (Arg splat experiment - syntax impl) - #157630 (Add multibyte JSON diagnostic regression test) - #157633 (Reorder `impl` restriction rendering and add bottom margin) - #157642 (Report duplicate relaxed bounds during ast lowering)

…jdonszelmann fix improper ctypes in Znext solver Fixes rust-lang#156352.

Rollup of 18 pull requests Successful merges: - #152852 (Remove driver_lint_caps) - #157166 (Change type of async context parameter after state transform.) - #157335 (bootstrap: Handle dotted table keys when parsing bootstrap.toml) - #157503 (Disable `tests/debuginfo/pretty-std.rs` `OsString` cdb check) - #157571 (Remove ProcMacro enum from proc macro ABI) - #148183 (rustdoc: Test & document `test_harness` code block attribute) - #153847 (Fix marker trait winnowing depending on impl order) - #156067 (Fix async drop glue for Box<T>) - #156399 (fix improper ctypes in Znext solver) - #157338 (Make `Literal::byte_character_value` work with bytes as well) - #157410 (Implement rustc_public::CrateDef{,Type} for FieldDef) - #157605 (Arg splat experiment - syntax impl) - #157630 (Add multibyte JSON diagnostic regression test) - #157633 (Reorder `impl` restriction rendering and add bottom margin) - #157642 (Report duplicate relaxed bounds during ast lowering) - #157652 (fix doc for unicode normalization faq on `casefold` APIs) - #157661 (Update to ar_archive_writer v0.5.2) - #157668 (Add test for matches in `rustc_must_match_exhaustively`) Failed merges: - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))

Rollup of 17 pull requests Successful merges: - #157166 (Change type of async context parameter after state transform.) - #157335 (bootstrap: Handle dotted table keys when parsing bootstrap.toml) - #157503 (Disable `tests/debuginfo/pretty-std.rs` `OsString` cdb check) - #157571 (Remove ProcMacro enum from proc macro ABI) - #148183 (rustdoc: Test & document `test_harness` code block attribute) - #153847 (Fix marker trait winnowing depending on impl order) - #156067 (Fix async drop glue for Box<T>) - #156399 (fix improper ctypes in Znext solver) - #157338 (Make `Literal::byte_character_value` work with bytes as well) - #157410 (Implement rustc_public::CrateDef{,Type} for FieldDef) - #157605 (Arg splat experiment - syntax impl) - #157630 (Add multibyte JSON diagnostic regression test) - #157633 (Reorder `impl` restriction rendering and add bottom margin) - #157642 (Report duplicate relaxed bounds during ast lowering) - #157652 (fix doc for unicode normalization faq on `casefold` APIs) - #157661 (Update to ar_archive_writer v0.5.2) - #157668 (Add test for matches in `rustc_must_match_exhaustively`) Failed merges: - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))

Rollup merge of #156399 - rajgandhi1:unexpected_type_fix, r=jdonszelmann fix improper ctypes in Znext solver Fixes #156352.

Rollup of 17 pull requests Successful merges: - rust-lang/rust#157166 (Change type of async context parameter after state transform.) - rust-lang/rust#157335 (bootstrap: Handle dotted table keys when parsing bootstrap.toml) - rust-lang/rust#157503 (Disable `tests/debuginfo/pretty-std.rs` `OsString` cdb check) - rust-lang/rust#157571 (Remove ProcMacro enum from proc macro ABI) - rust-lang/rust#148183 (rustdoc: Test & document `test_harness` code block attribute) - rust-lang/rust#153847 (Fix marker trait winnowing depending on impl order) - rust-lang/rust#156067 (Fix async drop glue for Box<T>) - rust-lang/rust#156399 (fix improper ctypes in Znext solver) - rust-lang/rust#157338 (Make `Literal::byte_character_value` work with bytes as well) - rust-lang/rust#157410 (Implement rustc_public::CrateDef{,Type} for FieldDef) - rust-lang/rust#157605 (Arg splat experiment - syntax impl) - rust-lang/rust#157630 (Add multibyte JSON diagnostic regression test) - rust-lang/rust#157633 (Reorder `impl` restriction rendering and add bottom margin) - rust-lang/rust#157642 (Report duplicate relaxed bounds during ast lowering) - rust-lang/rust#157652 (fix doc for unicode normalization faq on `casefold` APIs) - rust-lang/rust#157661 (Update to ar_archive_writer v0.5.2) - rust-lang/rust#157668 (Add test for matches in `rustc_must_match_exhaustively`) Failed merges: - rust-lang/rust#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N))

JonathanBrouwer · 2026-06-13T10:42:04Z

@rust-timer build 7d25f50

rust-timer · 2026-06-13T16:01:57Z

Finished benchmarking commit (7d25f50): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.1%, secondary -5.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-5.6%	[-5.6%, -5.6%]	1
All ❌✅ (primary)	-2.1%	[-2.1%, -2.1%]	1

Cycles

Results (secondary -3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.9%	[-3.9%, -3.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 525.47s -> 516.835s (-1.64%)
Artifact size: 400.80 MiB -> 401.36 MiB (0.14%)

rustbot assigned JohnTitor May 10, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 10, 2026

rustbot assigned lcnr and unassigned JohnTitor May 13, 2026

lcnr reviewed Jun 4, 2026

View reviewed changes

Comment thread compiler/rustc_lint/src/types/improper_ctypes.rs Outdated

jdonszelmann self-assigned this Jun 5, 2026

rajgandhi1 added 2 commits June 5, 2026 14:34

fix improper ctypes in Znext solver

dc14afd

constructs a TypingEnv with TypingMode::Borrowck now

9140c6c

rajgandhi1 force-pushed the unexpected_type_fix branch from a871502 to 9140c6c Compare June 5, 2026 10:11

rajgandhi1 requested a review from jdonszelmann June 6, 2026 16:33

jdonszelmann reviewed Jun 8, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2026

change comment

79df01a

rajgandhi1 requested a review from jdonszelmann June 8, 2026 10:07

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 8, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2026

jdonszelmann mentioned this pull request Jun 8, 2026

lint ImproperCTypes: refactor linting architecture (part 3) #146275

Open

add comments to justify skip normalization

c28609f

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2026

jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 9, 2026

Rollup merge of rust-lang#156399 - rajgandhi1:unexpected_type_fix, r=…

e0d39c9

…jdonszelmann fix improper ctypes in Znext solver Fixes rust-lang#156352.

jhpratt mentioned this pull request Jun 9, 2026

Rollup of 3 pull requests #157648

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 9, 2026

Rollup merge of rust-lang#156399 - rajgandhi1:unexpected_type_fix, r=…

49eef1f

…jdonszelmann fix improper ctypes in Znext solver Fixes rust-lang#156352.

GuillaumeGomez mentioned this pull request Jun 9, 2026

Rollup of 7 pull requests #157656

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 9, 2026

Rollup merge of rust-lang#156399 - rajgandhi1:unexpected_type_fix, r=…

538f54e

…jdonszelmann fix improper ctypes in Znext solver Fixes rust-lang#156352.

GuillaumeGomez mentioned this pull request Jun 9, 2026

Rollup of 10 pull requests #157663

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 9, 2026

Rollup merge of rust-lang#156399 - rajgandhi1:unexpected_type_fix, r=…

7bed013

…jdonszelmann fix improper ctypes in Znext solver Fixes rust-lang#156352.

GuillaumeGomez mentioned this pull request Jun 9, 2026

Rollup of 15 pull requests #157673

Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 9, 2026

Rollup merge of rust-lang#156399 - rajgandhi1:unexpected_type_fix, r=…

fdf2dfa

…jdonszelmann fix improper ctypes in Znext solver Fixes rust-lang#156352.

jhpratt mentioned this pull request Jun 9, 2026

Rollup of 18 pull requests #157679

Closed

jhpratt mentioned this pull request Jun 9, 2026

Rollup of 17 pull requests #157683

Merged

rust-bors Bot merged commit cfbbb01 into rust-lang:main Jun 10, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone Jun 10, 2026

rust-timer added a commit that referenced this pull request Jun 10, 2026

Unrolled build for #156399

7d25f50

Rollup merge of #156399 - rajgandhi1:unexpected_type_fix, r=jdonszelmann fix improper ctypes in Znext solver Fixes #156352.

This comment has been minimized.

Sign in to view

Uh oh!

Conversation

rajgandhi1 commented May 10, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 10, 2026

Uh oh!

Kivooeo commented May 10, 2026

Uh oh!

JohnTitor commented May 13, 2026

Uh oh!

Uh oh!

rustbot commented Jun 5, 2026

Uh oh!

Uh oh!

Uh oh!

jdonszelmann Jun 8, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajgandhi1 Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

jdonszelmann commented Jun 8, 2026

Uh oh!

rustbot commented Jun 8, 2026

Uh oh!

rajgandhi1 commented Jun 8, 2026

Uh oh!

jdonszelmann commented Jun 8, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 13, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jun 13, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rajgandhi1 commented May 10, 2026 •

edited by rustbot

Loading

jdonszelmann Jun 8, 2026 •

edited by rustbot

Loading