Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake by Oneirical · Pull Request #127095 · rust-lang/rust

Oneirical · 2024-06-28T19:06:32Z

Part of #121876 and the associated Google Summer of Code project.

Needs try-jobs.

try-job: x86_64-msvc
try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: i686-msvc
try-job: x86_64-mingw

rustbot · 2024-06-28T19:06:40Z

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-06-28T19:06:42Z

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

Kobzol · 2024-06-28T20:46:55Z

@bors try

Kobzol · 2024-06-28T20:46:59Z

r? @Kobzol

Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Needs try-jobs. try-job: dist-x86_64-musl try-job: x86_64-mingw

bors · 2024-06-28T20:48:06Z

⌛ Trying commit 1bbf359 with merge 863a69a...

bors · 2024-06-28T22:35:12Z

💔 Test failed - checks-actions

bors · 2024-06-29T20:54:49Z

☔ The latest upstream changes (presumably #126801) made this pull request unmergeable. Please resolve the merge conflicts.

Oneirical · 2024-07-09T17:52:28Z

Please run @bors try (no permissions).
@rustbot review

Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Needs try-jobs. try-job: x86_64-msvc try-job: armhf-gnu try-job: test-various try-job: aarch64-apple try-job: i686-msvc try-job: x86_64-mingw

bors · 2024-08-01T17:03:58Z

☀️ Try build successful - checks-actions
Build commit: 2bfec8e (2bfec8ebb7d971ca84024558ffb0818219eb49cd)

Oneirical · 2024-08-01T17:06:24Z

@rustbot review

jieyouxu

Cool

jieyouxu · 2024-08-02T02:42:46Z

@bors r+

bors · 2024-08-02T02:42:49Z

📌 Commit 94da7b1 has been approved by jieyouxu

It is now in the queue for this repository.

…eyouxu Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Needs try-jobs. try-job: x86_64-msvc try-job: armhf-gnu try-job: test-various try-job: aarch64-apple try-job: i686-msvc try-job: x86_64-mingw

Rollup of 9 pull requests Successful merges: - rust-lang#126704 (Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate) - rust-lang#127095 (Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake) - rust-lang#128107 (Migrate `raw-dylib-alt-calling-convention`, `raw-dylib-c` and `redundant-libs` `run-make` tests to rmake) - rust-lang#128161 (nested aux-build in tests/rustdoc/ tests) - rust-lang#128356 (Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake) - rust-lang#128404 (Revert recent changes to dead code analysis) - rust-lang#128483 (Still more `cfg` cleanups) - rust-lang#128528 (Finish removing `has_cpuid`) - rust-lang#128557 (chore: use shorthand initializer) r? `@ghost` `@rustbot` modify labels: rollup

…eyouxu Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Needs try-jobs. try-job: x86_64-msvc try-job: armhf-gnu try-job: test-various try-job: aarch64-apple try-job: i686-msvc try-job: x86_64-mingw

Rollup of 10 pull requests Successful merges: - rust-lang#126704 (Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate) - rust-lang#127095 (Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake) - rust-lang#127586 (Add `#[must_use]` to some `into_raw*` functions.) - rust-lang#128161 (nested aux-build in tests/rustdoc/ tests) - rust-lang#128303 (Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}`) - rust-lang#128356 (Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake) - rust-lang#128368 (Formatting tweaks) - rust-lang#128404 (Revert recent changes to dead code analysis) - rust-lang#128483 (Still more `cfg` cleanups) - rust-lang#128557 (chore: use shorthand initializer) r? `@ghost` `@rustbot` modify labels: rollup

…eyouxu Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Needs try-jobs. try-job: x86_64-msvc try-job: armhf-gnu try-job: test-various try-job: aarch64-apple try-job: i686-msvc try-job: x86_64-mingw

Rollup of 6 pull requests Successful merges: - rust-lang#127095 (Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake) - rust-lang#127921 (Stabilize unsafe extern blocks (RFC 3484)) - rust-lang#128466 (Update the stdarch submodule) - rust-lang#128530 (Implement `UncheckedIterator` directly for `RepeatN`) - rust-lang#128581 (Assert that all attributes are actually checked via `CheckAttrVisitor` and aren't accidentally usable on completely unrelated HIR nodes) - rust-lang#128603 (Update run-make/used to use `any_symbol_contains`) Failed merges: - rust-lang#128410 (Migrate `remap-path-prefix-dwarf` `run-make` test to rmake) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-08-05T12:16:09Z

⌛ Testing commit 94da7b1 with merge 83e9b93...

bors · 2024-08-05T14:38:25Z

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 83e9b93 to master...

rust-timer · 2024-08-05T16:36:52Z

Finished benchmarking commit (83e9b93): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 757.898s -> 758.182s (0.04%)
Artifact size: 336.81 MiB -> 336.79 MiB (-0.01%)

rustbot assigned jieyouxu Jun 28, 2024

Kobzol mentioned this pull request Jun 28, 2024

Tracking Issue for porting run-make tests to use Rust #121876

Closed

rustbot assigned Kobzol and unassigned jieyouxu Jun 28, 2024

Kobzol reviewed Jun 28, 2024

View reviewed changes

Comment thread tests/run-make/stable-symbol-names/rmake.rs Outdated

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2024

Oneirical force-pushed the testiary-education branch 2 times, most recently from ec6d82f to 1389aea Compare July 2, 2024 15:53

This comment has been minimized.

Sign in to view

Oneirical force-pushed the testiary-education branch from 1389aea to 9ce55cf Compare July 2, 2024 16:46

This comment has been minimized.

Sign in to view

Oneirical force-pushed the testiary-education branch 2 times, most recently from 31afcd4 to f4a8714 Compare July 9, 2024 17:51

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 1, 2024

jieyouxu approved these changes Aug 2, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 2, 2024

jieyouxu mentioned this pull request Aug 2, 2024

Rollup of 10 pull requests #128574

Closed

jieyouxu mentioned this pull request Aug 2, 2024

Rollup of 9 pull requests #128575

Closed

jieyouxu mentioned this pull request Aug 3, 2024

Rollup of 10 pull requests #128577

Closed

tgross35 mentioned this pull request Aug 3, 2024

Rollup of 6 pull requests #128608

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 5, 2024

bors merged commit 83e9b93 into rust-lang:master Aug 5, 2024

rustbot added this to the 1.82.0 milestone Aug 5, 2024

This was referenced Aug 5, 2024

Migrate remap-path-prefix-dwarf run-make test to rmake #128410

Merged

Migrate reproducible-build run-make test to rmake #128456

Merged

Uh oh!

Conversation

Oneirical commented Jun 28, 2024 • edited by jieyouxu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 28, 2024

Uh oh!

rustbot commented Jun 28, 2024

Uh oh!

Kobzol commented Jun 28, 2024

Uh oh!

Kobzol commented Jun 28, 2024

Uh oh!

bors commented Jun 28, 2024

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Jun 28, 2024

Uh oh!

bors commented Jun 29, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

Oneirical commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Aug 1, 2024

Uh oh!

Oneirical commented Aug 1, 2024

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Aug 2, 2024

Uh oh!

bors commented Aug 2, 2024

Uh oh!

bors commented Aug 5, 2024

Uh oh!

bors commented Aug 5, 2024

Uh oh!

rust-timer commented Aug 5, 2024

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Oneirical commented Jun 28, 2024 •

edited by jieyouxu

Loading

Oneirical commented Jul 9, 2024 •

edited

Loading