Re-enable uninlined_format_args on multiline format!#9945
Merged
Conversation
But do not display the code suggestion which can be sometimes completely broken (fortunately when applied it's valid)
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
Thank you! @bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Nov 25, 2022
Re-enable `uninlined_format_args` on multiline `format!` fix #9719 There was an issue with the code suggestion which can be sometimes completely broken (fortunately when applied it's valid), so we do not show it.
Contributor
|
💔 Test failed - checks-action_test |
Contributor
Author
|
seems a spurious failure |
Member
|
Ci failed because you need a |
Contributor
Author
|
thanks, updated |
Member
|
@bors r=llogiq |
Contributor
|
💡 This pull request was already approved, no need to approve it again.
|
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Nov 25, 2022
This was referenced Dec 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #9719
There was an issue with the code suggestion which can be sometimes completely broken (fortunately when applied it's valid), so we do not show it.
changelog: [
uninlined_format_args] re-enable for multiline format expression, but do not show the literal code suggestion in those cases