add documentation to the span_lint_hir functions#12445
Conversation
|
r? @Manishearth rustbot has assigned @Manishearth. Use r? to explicitly pick a reviewer |
xFrednet
left a comment
There was a problem hiding this comment.
I hope my comments are not too nit-picky :D
|
Changed the documentation a bit with (a lot of) inspiration taken from the suggestions
It's fine, especially for a PR like this. These functions are used everywhere, so imo having good documentation here is important. So feel free to point out things that you would phrase differently, even small details. |
|
Perfect, I like this version! This is a really nice improvement :D @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
As far as I could tell, these weren't documented anywhere, and since this is sometimes needed over
span_lintfor#[allow]attrs to work, I thought I would add a little bit of documentation.When I started with clippy development, I also had no idea what these functions were for.
changelog: none