new lint: [readonly_write_lock]#11210
Merged
Merged
Conversation
Collaborator
|
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Contributor
|
☔ The latest upstream changes (presumably #11115) made this pull request unmergeable. Please resolve the merge conflicts. |
giraffate
reviewed
Jul 27, 2023
giraffate
left a comment
giraffate
left a comment
Contributor
There was a problem hiding this comment.
Overall looks good, thanks! I made some comments.
Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com>
Contributor
|
@bors r+ Thanks! |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Member
Author
|
uhh... did bors get stuck merging the PR or what happened here? 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8555
A new lint that catches
RwLock::writecalls to acquire a write lock only to read from it and not actually do any writes (mutations).changelog: new lint: [
readonly_write_lock]