Add a Test Book to verify style changes against#1662
Merged
Conversation
This was referenced Oct 5, 2021
Merged
Contributor
Author
|
This can be used as follows : |
ehuss
approved these changes
Oct 24, 2021
ehuss
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this looks great and will be very useful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is no standard way to checking, verifying and validating changes done to styles or alignments of elements. Most of the time, people notice bugs in some mdBook book, and they fix and verify the fix on that book, see #1617 . This adds a test_book in the repo itself, which contains dummy examples of various tags by themselves and mixed together ; as well as examples of language snippets to validate changes in highlight.js (see point 8 in https://github.com/rust-lang/mdBook/blob/master/CONTRIBUTING.md#updating-higlightjs)
This is a big PR, in terms of additions, but none of it is any code changes to source code. All of it is addition of a new book in a directory called test_book.